Query Explorer improvements

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org

http://eclipse.org/viatra

13 stars 4 forks source link

Query Explorer improvements #173

Closed istvanrath closed 12 years ago

istvanrath commented 12 years ago

order pattern registry
- either alphabetically, or
- according to the order inside the eiq file --> this would be nice to have inside the explorer too!
synchronize selection between explorer tree and pattern registry
add "show location" functionality to pattern registry, just like it works now with the explorer
make sure to retain the closed/opened state of the details and pattern reg. panels
make the details panel open by default
if possible, make the pattern registry auto-open if patterns are registered for the first time

szabta89 commented 12 years ago

Pay attention for pattern unregistration as it influences the opening mechanism.

szabta89 commented 12 years ago

@CMark or @ujhelyiz Can you help me out with this issue; add "show location" functionality to pattern registry, just like it works now with the explorer? I want to know how to set a selection for the XText based pattern editor.

abelhegedus commented 12 years ago

https://github.com/ujhelyiz/EMF-IncQuery/blob/master/plugins/org.eclipse.viatra2.emf.incquery.tooling.gui/src/org/eclipse/viatra2/emf/incquery/queryexplorer/handlers/ShowLocationHandler.java#L73

I think it has everything you need. You should probably elevate that code if it's possible and not copy-paste it.

szabta89 commented 12 years ago

@abelhegedus It has the desired functionality, you have implemented it with the commit mentioned above.

abelhegedus commented 12 years ago

Actually, @ujhelyiz implemented the selection setting in the editor, I only prepared the proper editor and left an ugly sysout for him :D

ujhelyiz commented 12 years ago

Sorry, I don't understand what is the question here. :D The Show location handler referenced above provides a Command handler that selects a pattern in an Xtext editor. The same command should be added to the package registry, and then it should work (as far as I see).