search

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Query Explorer should properly dispose IncQueryEngine #177

Closed bergmanngabor closed 12 years ago

bergmanngabor commented 12 years ago

When (a) a model is unloaded or (b) the patterns are refreshed, the query explorer should dispose the old engine, to get rid of the old matchers which would otherwise linger in memory.

Further motivation: when re-registering a changed .eiq file, there will be lots of errors once #128 is resolved, since the old matchers are not disposed. One would have to quit & restart to resolve this. Can be reproduced using the sanitization branch.

Future TODO (after #9): instead of total disposal, use a smart wipe instead that will preserve the base index.

ujhelyiz commented 12 years ago

@szabta89 please provide some status report on this issue.

bergmanngabor commented 12 years ago

@szabta89 ninja'ed a Worksforme solution. The "Future TODO" part will be bumped to the next milestone.

bergmanngabor commented 12 years ago

FYI, wipe() is now available. If the patterns are reloaded, there is no need to completely dispose the engine, it is enought to wipe it (keeping the base index built directly on the EMF model).

istvanrath commented 12 years ago

@szabta89 I'm moving this back to 0.6, let's include this improvement.

istvanrath commented 12 years ago

UI-related tasks delegated to #238 and #239