viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

API: New registry method to gather all patterns in a package as a Group #181

Closed istvanrath closed 12 years ago

istvanrath commented 12 years ago

As per https://trac.inf.mit.bme.hu/VIATRA/wiki/IncQuery2/Meetings/20120611:

This is an additional task related to #14.

abelhegedus commented 12 years ago

The current implementation has two questionable additions to the specification:

Any of the above behaviour may seem unwanted/erroneous/smelly to you. Discuss! (or close the issue :D)

istvanrath commented 12 years ago

The only thing I would like to point out is that I thought it would be a good idea to introduce our own class for PatternGroups, instead of using plain Sets. The advantage would be that down the line, where we might need to add additional features to patterngroups, such changes would not break the API.

abelhegedus commented 12 years ago

I agree that an own class for groups is a good idea. However, I believe that it should be handled apart from the matcher factory registry. Actually, it should be each pattern group's responsibility to refresh their included patterns by calling the registry and the registry should remain independent of group objects and work only as a way to retieve patterns to create a group.

abelhegedus commented 12 years ago

Ready for use in #182