Closed abelhegedus closed 11 years ago
If they are in the same project, then it is a bug that it is required to open the first file to make the second one work.
If they are in different, independent projects, then it is a bug, that the dependency traverses between projects.
Finally, inter-file dependencies are basically untested now; they should work generally, but there might be some issues.
@istvanrath, please help to prioritize the issue.
They were in the same project, but different package.
@abelhegedus please verify that this issue is still valid
0.6: cross-file dependencies are officially unsupported
I could not reproduce the issue with the current version.
This issue seems to be solved. Since the commits mentioned here, patterns from other files are only visible if they are in the same package, or they are imported using the new Java import mechanism. See test case updates for syntax.
Are our concerns with Pattern object identity resolved yet?
Is pattern pA, as parsed from pa.eiq, the same Java Object as pattern pA, as referenced from pattern pB that in turn was parsed from pb.eiq? This raises different concerns in runtime and in generated pattern code.
You are right - I was wondering in the afternoon, why haven't I closed this ticket weeks ago, and only remembered it while coming home... :D
That issue is not resolved yet, so I removed the Resolved tag...
+1 concern (already discussed verbally): from pA.eiq, can I reference patterns in other workspace projects (along bundle dependencies), as well as generated patterns already plugged in the Eclipse instance?
Remaining issue followed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=398800
This may be a feature, not a bug:
somepackage/somequeries.eiq:
otherpackage/otherqueries.eiq:
If you open the second .eiq, the find X is unresolved, and an error is shown. If you open the first .eiq, the X pattern will be found and the second .eiq will be correct.
There is no indication that the two .eiq files are dependent upon each other in any way.