search

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

IncQuery Selection Spy: Query Explorer should be able to import instance models from Views too (not only Editors) #219

Closed istvanrath closed 11 years ago

istvanrath commented 12 years ago

The title says it all.

ujhelyiz commented 12 years ago

Please, specify what views are in your mind. In theory, the command framework based loader can be extended with any specific code and activation condition, but has to be done manually.

istvanrath commented 12 years ago

The support should not be specific to a particular (type of) View, but should work whenever there is an EObject in the Selection (encapsulated).

ujhelyiz commented 12 years ago

And how do you imagine that support - in the main toolbar, or in a pop-up menu?

I am asking this because the button in the Query Explorer view will not work, as I can check the selection of the active view (if I know it right, itself :( ), or a specified view.

We can extend other pop-up menus with the same commands, just we have to make sure we are not too intrusive.

istvanrath commented 12 years ago

Let us not limit ourselves by a design issue with the current implementation. It is clear that IncQuery needs a generic import facility that is able to work with models displayed inside Views, as some tools do not necessarily expose nstance models through an Editor UI.

The Query Explorer's current limitations could be worked around by e.g. tracking active view changes with a "memory" and taking not the currently active view into account, but e.g. the one which was active before the user switched back to the Query Explorer.

Another option is to implement a "plug-in spy"-like functionality, whereby the user could invoke IncQuery's import feature through a "hovering pop-up" dialog (I don't know the exact API name for this, forgive me).

ujhelyiz commented 12 years ago

Tracking view changes seems more like a hack to me bound to go wrong. However, the plug-in spy idea is nice - after executing the command, simply click on the item you want to import (similar to the menu spy feature).

Now the question is whether this will fit in the 0.6.0 timeline - sorry, it is 0.6.0 optional now.

istvanrath commented 12 years ago

Let's discuss this then on the monday meeting.

istvanrath commented 11 years ago

Moved to Eclipse.org: https://bugs.eclipse.org/bugs/show_bug.cgi?id=398715