viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Query Explorer: wildcard mode adjustments #239

Closed istvanrath closed 12 years ago

istvanrath commented 12 years ago
istvanrath commented 12 years ago

Please add some short description to the preference page, either as a hover help, or otherwise. The text could be e.g. "Turn off wildcard mode to decrease the memory usage while working with very large models during query development."

szabta89 commented 12 years ago

@istvanrath OK! Yesterday we discussed the issue with @bergmanngabor and it seemed that the size of the match sets are different when wildcard mode is turned on/off.

szabta89 commented 12 years ago

I think this issue is resolved, however the previously mentioned erroneous behavior is still present.

istvanrath commented 12 years ago

So you should report a separate issue for that, with a description on how to reproduce it.

bergmanngabor commented 12 years ago

I have slightly updated the text on the preference page.

I also committed another improvement: in case of group initialization (i.e. when wildcard mode is off), the error feedback if a pattern matcher construction throws an exception is now not as bad as it used to be; it looks similar to the version without group initialization, in that the exception is localized to a single matcher entry on the GUI. I needed some pretty deep API hacking, so no wonder @szabta89 did not solve it this way.

Also, #247 is now resolved.

Before closing this issue, I think a final task needs to be addressed:

szabta89 commented 12 years ago

Needs further investigation as the previous commit did not fully solve the issue.

istvanrath commented 12 years ago

@szabta89 please check whether wildcard mode is on by default (in a new Eclipse workspace)

szabta89 commented 12 years ago

I have checked it and wildcard mode is on by default.