search

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Derived features in the pattern language should be reviewed thoroughly #260

Closed bergmanngabor closed 12 years ago

bergmanngabor commented 12 years ago

We have observed some strange behaviour in VariableReference.variable and PatternBody.variables. Please review thoroughly the implementation of all derived features in the packages.

Example: whenever body.getVariables() is called, it re-sets all variables to their present values again.

ujhelyiz commented 12 years ago

See also #262 - that is also related but a more concrete issue.

ujhelyiz commented 12 years ago

262 is now resolved - the remaining things for this issue (after a discussion with @bergmanngabor):

  1. There are no other derived features present in the Pattern Model.
  2. The single known issue seems fixed with #262.
  3. The example Gábor mentioned is an extraneous notification that does not cause any problems, only some performance issues. However, I believe, the performance problem is not as serious as e.g. the builder speed issues, so I suggest pushing this issue to a later milestone. If the slowdown is more critical, feel free to push back this issue to 0.6.5.