viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Plug-in patterns cannot be unregistered in Query Explorer #278

Closed okrosa closed 11 years ago

okrosa commented 12 years ago

Patterns with @QueryExplorer(display = true) annotations show up in the Query Explorer's plug-in pattern registry, but from here they can't be removed. (It is a little bit annoying, because if you're developing them parallelly in the runtime they can't be registered into the system as runtime patterns due to the same names.)

szabta89 commented 12 years ago

I could not reproduce the issue. I could unregister both patterns with @QueryExplorer(display = true) or just @QueryExplorer and with @QueryExplorer(display = false) too.

okrosa commented 12 years ago

I don't really understand your point, patterns with @QueryExplorer(display = false) does not even show up in the pattern registry's plug-in part, corretly. (Note I copied the project back to the host eclipse!) Unregistering the patterns with @QueryExplorer(display = true) or @QueryExplorer, only removes the tick from checkbox leaving them in the registry.

2012/8/27 szabta89 notifications@github.com

I could not reproduce the issue. I could unregister both patterns with @QueryExplorer(display = true) or just @QueryExplorer and with @QueryExplorer(display = false) too.

— Reply to this email directly or view it on GitHubhttps://github.com/ujhelyiz/EMF-IncQuery/issues/278#issuecomment-8049307.

szabta89 commented 12 years ago

So you have generated code in your host eclipse and the patterns are coming from that plug-in?

okrosa commented 12 years ago

Yes! Sorry, if the bug description was misleading!

2012/8/28 szabta89 notifications@github.com

So you have generated code in your host eclipse and the patterns are coming from that plug-in?

— Reply to this email directly or view it on GitHubhttps://github.com/ujhelyiz/EMF-IncQuery/issues/278#issuecomment-8088099.

szabta89 commented 12 years ago

Then it is the expected behaviour not to allow the unregistration of patterns because later you could not register them again (only if you restart the runtime Eclipse - this way they will be collected upon init). It works this way by design.

ujhelyiz commented 12 years ago

Needs a Query Explorer redesign - bumping.

istvanrath commented 11 years ago

This issue doesn't need migration to Eclipse as the UI is under redesign at the moment.