viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

matcher factory extension generation buggy #289

Closed abelhegedus closed 11 years ago

abelhegedus commented 12 years ago

In some cases (I don't have a way to reproduce it, although it occurred twice in the last two days), the code generator doesn't clean the matcherfactory annotations but transforms them from the correct:

<extension
         id="testing.queries.RecordRoleValue"
         point="org.eclipse.viatra2.emf.incquery.matcherfactory">
      <matcher
           factoryProvider="testing.queries.recordrolevalue.RecordRoleValueMatcherFactory$Provider"
            id="testing.queries.RecordRoleValue">
      </matcher>
   </extension>

to the mind boggling:

<extension
         id="RecordRoleValue"
         name=""
         point="org.eclipse.viatra2.emf.incquery.matcherfactory">
      <matcher
            id="testing.queries.RecordRoleValue"
            factoryProvider="testing.queries.recordrolevalue.RecordRoleValueMatcherFactory$Provider">
      </matcher>
   </extension>

Subsequent code generation rounds seems to transform the correct extensions of the last round to the strange version and creating new correct ones.

abelhegedus commented 12 years ago

We managed to reproduce it deterministically:

For example, testing.queries

ujhelyiz commented 12 years ago

Fixed in master.