Unexpected runtime error while computing a text hover

istvanrath commented 12 years ago

Unfortunately, I haven't found a deterministic way to reproduce this issue yet, I'm just getting the exceptions.

!ENTRY org.eclipse.jface.text 4 0 2012-09-25 16:06:01.148
!MESSAGE Unexpected runtime error while computing a text hover
!STACK 0
org.eclipse.swt.SWTException: Failed to execute runnable (org.eclipse.xtext.conversion.ValueConverterException: ID '=>' contains invalid characters: '>' (0x3e), '=' (0x3d))
    at org.eclipse.swt.SWT.error(SWT.java:4361)
    at org.eclipse.swt.SWT.error(SWT.java:4276)
    at org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:196)
    at org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:150)
    at org.eclipse.swt.widgets.Display.syncExec(Display.java:4605)
    at org.eclipse.xtext.ui.editor.hover.AnnotationWithQuickFixesHover.getHoverInfoInternal(AnnotationWithQuickFixesHover.java:692)
    at org.eclipse.xtext.ui.editor.hover.AbstractProblemHover.getHoverInfo2(AbstractProblemHover.java:56)
    at org.eclipse.xtext.ui.editor.hover.AbstractCompositeHover.getHoverInfo2(AbstractCompositeHover.java:90)
    at org.eclipse.jface.text.TextViewerHoverManager$4.run(TextViewerHoverManager.java:166)
Caused by: org.eclipse.xtext.conversion.ValueConverterException: ID '=>' contains invalid characters: '>' (0x3e), '=' (0x3d)
    at org.eclipse.xtext.conversion.impl.AbstractIDValueConverter.createTokenContentMismatchException(AbstractIDValueConverter.java:76)
    at org.eclipse.xtext.conversion.impl.AbstractIDValueConverter.createTokenContentMismatchException(AbstractIDValueConverter.java:1)
    at org.eclipse.xtext.conversion.impl.AbstractLexerBasedConverter.assertTokens(AbstractLexerBasedConverter.java:53)
    at org.eclipse.xtext.conversion.impl.AbstractLexerBasedConverter.toString(AbstractLexerBasedConverter.java:44)
    at org.eclipse.xtext.conversion.impl.AbstractDeclarativeValueConverterService.toString(AbstractDeclarativeValueConverterService.java:58)
    at org.eclipse.xtext.conversion.impl.KeywordAlternativeConverter.toString(KeywordAlternativeConverter.java:48)
    at org.eclipse.xtext.conversion.impl.KeywordAlternativeConverter.toString(KeywordAlternativeConverter.java:1)
    at org.eclipse.xtext.conversion.impl.AbstractDeclarativeValueConverterService.toString(AbstractDeclarativeValueConverterService.java:58)
    at org.eclipse.xtext.conversion.impl.KeywordAlternativeConverter.toString(KeywordAlternativeConverter.java:48)
    at org.eclipse.xtext.conversion.impl.KeywordAlternativeConverter.toString(KeywordAlternativeConverter.java:1)
    at org.eclipse.xtext.conversion.impl.AbstractDeclarativeValueConverterService.toString(AbstractDeclarativeValueConverterService.java:58)
    at org.eclipse.xtext.ui.editor.quickfix.DefaultQuickfixProvider$1.createResolution(DefaultQuickfixProvider.java:160)
    at org.eclipse.xtext.ui.editor.quickfix.DefaultQuickfixProvider$1.process(DefaultQuickfixProvider.java:124)
    at org.eclipse.xtext.ui.editor.quickfix.DefaultQuickfixProvider$1.process(DefaultQuickfixProvider.java:1)
    at org.eclipse.xtext.util.concurrent.IUnitOfWork$Void.exec(IUnitOfWork.java:36)
    at org.eclipse.xtext.util.concurrent.AbstractReadWriteAcces.readOnly(AbstractReadWriteAcces.java:32)
    at org.eclipse.xtext.ui.editor.model.XtextDocument.readOnly(XtextDocument.java:78)
    at org.eclipse.xtext.ui.editor.quickfix.DefaultQuickfixProvider.createLinkingIssueResolutions(DefaultQuickfixProvider.java:97)
    at org.eclipse.xtext.ui.editor.quickfix.DefaultQuickfixProvider.getResolutionsForLinkingIssue(DefaultQuickfixProvider.java:88)
    at org.eclipse.xtext.ui.editor.quickfix.DefaultQuickfixProvider.getResolutions(DefaultQuickfixProvider.java:202)
    at org.eclipse.xtext.ui.editor.quickfix.AbstractIssueResolutionProviderAdapter.getResolutions(AbstractIssueResolutionProviderAdapter.java:42)
    at org.eclipse.xtext.ui.editor.quickfix.XtextQuickAssistProcessor.createQuickfixes(XtextQuickAssistProcessor.java:119)
    at org.eclipse.xtext.ui.editor.quickfix.XtextQuickAssistProcessor.computeQuickAssistProposals(XtextQuickAssistProcessor.java:95)
    at org.eclipse.xtext.ui.editor.hover.AnnotationWithQuickFixesHover$CompletionProposalRunnable.run(AnnotationWithQuickFixesHover.java:592)

ujhelyiz commented 12 years ago

Ok, I have found a deterministic way to reproduce this, and also did some debugging:

It happens, when the Xbase '>' operator cannot be resolved (e.g. not having the fix for #304 in the workspace, but removing the type casts from the comparison)
Then ask a hover over the Xbase expression.

After some debugging I found out that

Xtext tries to suggest similar operators that might be usable.
It deems the '=>' operator similar enough to return.
For some reason (not sure why yet) it tries to use it as an Identifier.
And finally, '=>' is not a valid identifier.

Not the only thing remains to find a fix.

ujhelyiz commented 12 years ago

Even worse - issue reproducible using the pure Xbase language (available in the Xbase tutorial Xtext example...). I will look for corresponding issues in the Eclipse Bugzilla.

istvanrath commented 12 years ago

I don't regard this issue as a show-stopper for 0.6.5.

ujhelyiz commented 12 years ago

I just filled a bug report for Xtext: https://bugs.eclipse.org/bugs/show_bug.cgi?id=390595

Postponing until we get an answer to that.

ujhelyiz commented 11 years ago

It is fixed for Xtext 2.4. As we are not compatible with it (#280), we cannot test it yet. But in the future, we won't have this issue.

ujhelyiz commented 11 years ago

Migrated to https://bugs.eclipse.org/bugs/show_bug.cgi?id=398820

viatra / EMF-IncQuery

Unexpected runtime error while computing a text hover #306