viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Ensure that Xbase check expressions only use scalar variables #346

Closed istvanrath closed 11 years ago

istvanrath commented 11 years ago

The task is to ensure (at editing time) that Xbase check expressions only access scalar pattern variables (EStrings, EInts, datatypes etc):

A solution to this issue obsoletes #312 and provides a minimal solution to #96.

okrosa commented 11 years ago

I commited a new validator which checks whether the variables in the check expression are only EDataTypes. I think we don't need more to handle this issue, so I set it to resolved.

ujhelyiz commented 11 years ago

Did you try to enter a variable containing an EObject using content assist?

okrosa commented 11 years ago

Yes, the content assist in an empty check constraint does not propose variables at all now, so it is not misleading. (However not 100% percent helpful at the same time, as the usable variables are missing as well.)

istvanrath commented 11 years ago

@okrosa please cherry pick into maintenance branch

okrosa commented 11 years ago

Cherry pick completed.

istvanrath commented 11 years ago

OK - works also with custom datatypes and enums! Well done!