search

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Common model connector #351

Closed okrosa closed 11 years ago

okrosa commented 11 years ago

Working on the #347 issue I came across some duplications in our codebase. The GMF handling parts of the code is basically doing the same as the EMF parts with small differences. The original code was copied, and I even managed to found a minor difference (a missing null check in the GMF BasePartListener implementation).

The root cause of the #347 was that the logic of how to "excavate" the resourceset from a given editorpart can be found in two places now, and should be updated everywhere for proper loading and unloading. (There are still parts of the GMFModelConnector which might not work properly with a Papyrus editor.)

This is just a feature proposal; to look into the underlying logic of the UI, and rewrite the parts so no duplication is left in the system in this area. I think after the high priority elements this should be included in the next milestone as it would improve the robustness of the existing ui, which is one of our key targets now.

istvanrath commented 11 years ago

I'm giving this a +1 and the red badge for high priority issues.

okrosa commented 11 years ago

This third commit should make the system work like it did before my refactors. :) The GMF parts are more-or-less cleaned from the redundancies, but I'll leave this ticket open now (we should look into what parts might need further enhancements).

ujhelyiz commented 11 years ago

We will manage this issue with @okrosa on the eclipse migration hackathon.

okrosa commented 11 years ago

I look into this ticket and the main work (removing the duplications) is done already. The current api can be enhanced further, but I think it has a very low priority now, so I'll close this ticket and won't open it on Eclipse.