Closed okrosa closed 11 years ago
The QueryExplorer tag is necessary for generated patterns to be included into the Pattern Registry.
The tag is there, that is why the patterns show up in the first place in the plug-in pattern registry. The fact, that I comment out the whole pattern after in the eiq file should not affect at all the generated code in the host eclipse (which is not changed after the first export).
Action plan to resolve this issue:
Action plan item 1 relates to #281 - more specifically, a solution for this essentially blocks all use cases for dependencies.
A minor remark about action plan 2: it is surprisingly hard to write a validation that relies that much on Eclipse context. That kind of information is not available there - in the Xtext those validators are not really supported.
Please elaborate more on your first remark ("blocks all use cases for dependencies").
Sorry for not being clear (midnight effect :) ). I wanted to say, that the removing the workspace dependency (workspace lookup) is required to even consider a non-Eclipse integration of EMF-IncQuery based on the generated pattern matcher code.
However, as the fix of #172 added new dependencies of incquery.runtime, this is not the only place needs to be fixed to support Java applications (without OSGi), but it is still an important step.
First part (bugfix):
Second part (extra validator): based on the comment of @ujhelyiz I suggest we should not deal with it now, as this whole issue is quite marginal.
Based on this if my last commit is decided to be sufficient I'll be propose to set this issue to resolved as well.
Cherry pick completed.
Everything seems to be working fine so I'm closing this.
Might be related to #302, but I will open a separate issue for sure.
I made some patterns with the @QueryExplorer tag, and exported them into the host eclipse. After restarting the runtime the patterns show up in the Query Explorer correctly. (During this the eiq files with the pattern definitions are opened in the runtime.) If I comment out the tagged patterns and restart the eclipse I got an error, and the patterns does not show up in the plug-in part of the registry.