search

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

Nested genpackages are not supported using eiqgen #353

Closed abelhegedus closed 11 years ago

abelhegedus commented 11 years ago

When trying to import EPackages that are nested (see gtasm model :smiley: ), only the toplevel package can be imported, the others are missing from the content assist list.

Additionally, manually entering the nsUri doesn't help either (so not content assist bug, but genmodel provider).

The relavant method is GenModelMetamodelProviderService.getAllMetamodelObjects(Eobject ctx), https://github.com/ujhelyiz/EMF-IncQuery/blob/master/plugins/org.eclipse.viatra2.emf.incquery.tooling.generator/src/org/eclipse/viatra2/emf/incquery/tooling/generator/genmodel/GenModelMetamodelProviderService.java#L103

You can see, that at line 103, only the toplevel GenPackage is selected, the GenPackage.getNestedGenPackages is not called.

istvanrath commented 11 years ago

Promoting this to 0.6.8 as it is an important bugfix.

istvanrath commented 11 years ago

@ujhelyiz or @okrosa someone please take a look.

ujhelyiz commented 11 years ago

How important is to fix this before the next weekend (2012.11.17)? If it is enough to do it then, I can do it (it seems reasonably easy to fix it). However, I do not want to think about all possible side-effects changing the resolution mechanism before that.

istvanrath commented 11 years ago

@okrosa please take a look at this issue as @ujhelyiz doesn't have time for it now.

okrosa commented 11 years ago

I made some minor changes and now the imports are working fine. @abelhegedus please try if it works for you now! (I have no idea whether I introduced some side-effects as well or not.)

abelhegedus commented 11 years ago

It works for me as well, thanks!

okrosa commented 11 years ago

Cherry pick completed.