search

viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

NPE in ProjectGenerationHelper #380

Closed okrosa closed 11 years ago

okrosa commented 11 years ago

The isRemoveableExtension method in the ProjectGenerationHelper is called with a null extensionId String. This results in a NPE, which does not seem to cause any problem (apart from breaking my debugging every time I start the runtime eclipse :-) ).

ujhelyiz commented 11 years ago

Can you at least provide an exception trace? This seems to be a double issue - one that throws the exception; but the code generator should not call the ProjectGenerationHelper with null ids.

ujhelyiz commented 11 years ago

After a tematic skype-meeting with @okrosa that the issue cannot be reproduced and a quick code review we believe that the issue happens when an extension is available in the in-memory model with a null id.

That case is certainly hard to reproduce (more generally, it shouldn't happen at all :) ), and the cause might solve itself, I suggest leaving this issue open until someone manages to reproduce it with more information.

ujhelyiz commented 11 years ago

Yesterday I realized that extension id might be null; the extension point id of the extension shouldn't be. I added a simple null check to solve this issue.

istvanrath commented 11 years ago

Assumed to be fixed.