viatra / EMF-IncQuery

This repository is only kept for historic reasons. All development happens on eclipse.org
http://eclipse.org/viatra
13 stars 4 forks source link

PatternLanguage.ecore contains local paths so that one cannot refer to IncQuery metaclasses in a separate ecore model #386

Closed jreimone closed 11 years ago

jreimone commented 11 years ago

In my own metamodel I want to refer to your metaclass 'Pattern'. So I loaded it from the registry and referenced the according metaclass. Then I got errors when reloading the genmodel. I couldn't resolve them by loading additional xtext metamodels. So I downloaded the sources of the patternlanguage core plugin and had a textual look at the PatternLanguage.ecore and found two inappropriate type references which evoke the problem:

1) metaclass Variable has the following string as eSuperTypes: ../../../../../../../org.eclipse.xtext.common.types/model/JavaVMTypes.ecore#//JvmIdentifiableElement I changed it to platform:/plugin/org.eclipse.xtext.common.types/model/JavaVMTypes.ecore#//JvmIdentifiableElement

2) metaclass CheckConstraint had the following string for the eStructuralFeature 'expression': eType="ecore:EClass ../../../../../../../org.eclipse.xtext.xbase/model/Xbase.ecore#//XExpression" I changed it to ecore:EClass platform:/plugin/org.eclipse.xtext.xbase/model/Xbase.ecore#//XExpression

Now my generator model could be reloaded correctly. I recommend to refer to the appropriate ecore files with "platform:/plugin..." instead of your local "platform:/resource..." since I assume that you had a local copy of the Xtext plugins.

ujhelyiz commented 11 years ago

Sadly, those ecore files are generated by the Xtext code generation workflow instead of being manually created so the required change does not seem trivial at first.

However, could you please re-open this issue in the eclipse.org Bugzilla, as this project has moved all its development there? See the link https://bugs.eclipse.org/bugs/enter_bug.cgi?product=incquery.

Thanks.

jreimone commented 11 years ago

https://bugs.eclipse.org/bugs/show_bug.cgi?id=401552