method to register event action should start with event name and have 'Action' postfix.
setter should have prefix 'set' because some getters may accept parameters as options.
if a method's object is clear, the object should be skipped in in method name.
In ServerHttpExchange, requestHeader(String name) should be renamed to header(String name) and setResponseHeader(String name, String value) should be renamed to setHeader(String name, String value). Well, is it too much?
The current one for class.
class name should not include word about project, vibe, and should include min words explaining what it is even though its package name already explains that. But I didn't think of it particularly so what criteria would be helpful to make a decision?.
Socket in org.atmosphere.vibe.server should be renamed to ServerSocket.
Just to be sure. The above policy is not absolute. If some class has many more setter than getter like Options or OptionsBuilder class, setter can have no prefix and getter should have prefix 'get'.
As package name is fixed in https://github.com/Atmosphere/vibe-java-server/issues/30, we need to have naming policy for class/method.
The current one for method.
ServerHttpExchange
,requestHeader(String name)
should be renamed toheader(String name)
andsetResponseHeader(String name, String value)
should be renamed tosetHeader(String name, String value)
. Well, is it too much?The current one for class.
Socket
inorg.atmosphere.vibe.server
should be renamed toServerSocket
.What do you think?