search

vibertthio / muse

✍️ Poem → 🎵 Music
https://vibertthio.com/muse
3 stars 0 forks source link

Weird pitch selection logic #1

Open vibertthio opened 4 years ago

vibertthio commented 4 years ago

https://github.com/vibertthio/muse/blob/3fefca1058dbb1a157d765fef4d6345ff752e627/script.js#L107-L119

it uses pop to get the last pitch out of closeTones, medTones, or farTones. However, there will all be used if the input text more than about 30 words. I think there must be some mistakes?

squidgetx commented 4 years ago

this is intentional part of the old design. It's not very good and we should definitely think of a better way to do this. Note that if the input text is 30 words but none of them have similarity < 0.1 then none of the farTones will be used though