vibes-863 / pe

0 stars 0 forks source link

Loading of corrupted data gets deleted without letting user know #8

Open vibes-863 opened 2 months ago

vibes-863 commented 2 months ago

image.png

I changed the number of classes attended from 40 to 40.00. When i then started the application, it showed "Invalid Number format found" and then says "Test 1 added successfully"

image.png

But when we view that students details, it can be seen that there is no subjects and that it was deleted.

image.png

This wasnt told to the user.

soc-se-bot commented 2 months ago

Team's Response

image.png

In the UG, it is clearly stated here, written at bullet point 6:

image.png

Hence, it was told to the user.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

no error handling of dates later than today

image.png

if user manually edits the data file as such, i.e. changing last payment date to a future date, the application runs as per normal:

image.png


[original: nus-cs2113-AY2324S2/pe-interim#89] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We have mentioned not to edit the save file in the user guide. Any data input by the user through editing the save files is thus up to their own onus.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The bug that has been marked as duplicate talks about editing the date to a future date and the app still accepting it. Whereas, the bug mentioned in my bug report is related to the deletion of the student without letting the user know when the number of classes attended is manually changed from integer to double in the Student_information.txt file.

Thus these are not duplicate bugs.

image.png

It also does not fall under the above two cases (a & b).


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** The bullet point mentioned by the team in the response states " 6. Please do not edit the save files Student_Information.txt or student_archive.txt". How does this inform the user that the student details will be deleted if the user manually changed the number of classes attended from 40 to 40.00 in the Student_information.txt file? The reason given by the team does not justify the rejection of the bug. Furthermore, the point 6 which was referred above should not be there in the UG as it asks the user to not edit the data files which contradicts the tp constraints. The constraint is shown below: ![image.png](https://raw.githubusercontent.com/vibes-863/pe/main/files/a75d3787-4244-4ad6-a4dc-c8128b5c83e3.png)
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** The team has not given a reason for why it is a functionalityBug and not a featureFlaw
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** The team has not given a reason for why the severity is Low and not Medium