search

vibhorkum / pg_background

pg_background
GNU General Public License v3.0
136 stars 35 forks source link

Fix compatibility with pg14 #35

Closed rjuju closed 3 years ago

rjuju commented 3 years ago

Hi,

Right now pg_background would compile on pg14 but will fail as hash_create() now requires to explicitly provide a hash method (see the commit message for more details).

I'm also adding some basic regression test to quickly validate that the extension works as expected.

vibhorkum commented 3 years ago

Thank you, @rjuju for submitting the patch! Merged the PR.

rjuju commented 3 years ago

Thanks @vibhorkum !

didmicang commented 3 years ago

Hi @rjuju and @vibhorkum Would it be possible to publish a release version of pg_background extension. Devrim Gunduz need a tarball in order to put this extension into the PGDG repository ... Thanks in advance

rjuju commented 3 years ago

@didmicang I totally agree, but as far as I know only @vibhorkum can do that, since it's his repository and he's the only one with commit privileges.

didmicang commented 3 years ago

@vibhorkum : Can you tell us if it is possible to have a production version ?

@rjuju : (1) Are you saying that it is not possible to use the pg_backgroud extension in PostgreSQL 10,11,12,13? (2) Do you think it is possible to make a clone of the "pg_background" GIT project that you own?

Thanks in advance

rjuju commented 3 years ago

@didmicang

1) this PR only added compatibility with pg14. pg_background should work down to pg 9.5, and this PR didn't change that. I just tried with pg 9.5 and it's still working fine, at least with the new regression test this PR added.

2) Yes that's of course possible, but IMO that's not very nice way to handle the problem. It seems to me that @vibhorkum should chose whether he's committed to properly maintain the project and do it, or ask if other people would be willing to do so. If the latter (and assuming there are trustworthy volunteer(s)), then moving the repository to a new dedicated organization and giving ownership to the volunteer(s) would probably be the best way to go.

vibhorkum commented 3 years ago

I just saw the message. @rjuju, I will give you the commit privileges. @didmicang I will create a new branch for Devirm.