vibhorkum / pg_background

pg_background
GNU General Public License v3.0
147 stars 36 forks source link

v_1.2 release zip is missing files #53

Closed probitdavid closed 4 months ago

probitdavid commented 9 months ago

The v_1.2 zip is missing

asphator commented 4 months ago

Any update ?

vibhorkum commented 4 months ago

Fixed. Thank you for reporting!

asphator commented 4 months ago

Confirmed, thx a lot

asphator commented 3 months ago

@vibhorkum , Makefile is missing those files too Fix suggested: DATA = pg_background--*.sql

vibhorkumar123 commented 3 months ago

Interesting. Checking now

vibhorkumar123 commented 3 months ago

I checked. It's there

Screenshot 2024-06-12 at 09 05 55
asphator commented 3 months ago

Sorry for the delay.

Indeed, the files are there:

But when you want to compile from sources, you use the Makefile (for make and make install). Makefile contains only DATA = pg_background--1.2.sql Thus, it will never work. Must also include other intermediate SQL files. I did a quick fix/override (the one suggested above) in our CI but would benefit everybody to fix it at the source.

vibhorkum commented 2 months ago

Can you please re-check? Thank you!

probitdavid commented 2 months ago

yep all good now

asphator commented 2 months ago

Thank you very much :)