search

vibinex / chrome-extension

This chrome extension adds actionable overlays based on the company's data (code, deployments and success metrics)
10 stars 6 forks source link

storage change from sync to local #73

Closed avikalpg closed 1 year ago

avikalpg commented 1 year ago

According to the documentation, chrome.storage.sync should have behaved exactly like chrome.storage.local when sync is disabled.

But with one of the users, we observed otherwise. We saw that the extension was not working unless sync was enabled.

Since in our case, there isn't any real advantage to using sync, it is better that we use the more robust type of storage.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

vibinex-code-review[bot] commented 1 year ago
Relevant users for this PR: Contributor Name/Alias Code Coverage
@ajayVibinex 100.00%

Auto-assigning to following reviewers: @ajayVibinex

Code coverage is calculated based on the git blame information of the PR. To know more, hit us up at contact@vibinex.com. To change comment and auto-assign settings, go to your Vibinex settings page.