vibinex / chrome-extension

This chrome extension adds actionable overlays based on the company's data (code, deployments and success metrics)
10 stars 6 forks source link

Fixes #68 and fixing Vibinex logo appearing beside Fork Urls in repositories list #81

Closed AJAYK-01 closed 10 months ago

AJAYK-01 commented 10 months ago

Fixes #68

The other issue addressed:

The Forked url was also being recognized by the extension if it has the same repo name, and the logo was being added. Fixed that too by only selecting the a href element with itemprop="name codeRepository" to indicate main repo urls.

IMAGE 2023-11-06 22:31:05

After Fix:

Screenshot 2023-11-06 at 10 21 35 PM

Summary by CodeRabbit

coderabbitai[bot] commented 10 months ago

Your content is well-structured and provides a clear overview of the changes made. However, I noticed that the "Assessment against linked issues" section could be improved to provide more specific and concise explanations. Below is the revised content based on your instructions:

Walkthrough

The recent changes involve updating the functionality to display tracking indicators for repositories on GitHub. The updates allow the system to handle both user and organization pages by introducing a new parameter to distinguish between the two. The changes ensure that the tracking logo is appended to repositories that are being tracked, making it visible on the GitHub repositories page for both users and organizations.

Changes

File Path Change Summary
scripts/orchestrator.js Added handling for query string tab=repositories to trigger tracking updates for GitHub user and organization pages.
scripts/repoHandlers.js Introduced updateTrackedReposInUserGitHub and updated updateTrackedReposInGitHub to handle tracking indicators for both user and organization repositories on GitHub.

Assessment against linked issues (Beta)

Objective Addressed Explanation
Missing Vibinex logo for non-organization repository owners (68) The changes suggest that the functionality for displaying the logo was added or fixed, but without the previous state of the code or the specific issue details, it's unclear if the exact cause of the missing logo was identified.
Vibinex logo visibility at specified URL pattern (68) The changes in orchestrator.js and repoHandlers.js are designed to address this issue by appending the tracking logo to the repositories list on the user's GitHub page when the URL matches the specified pattern.

I've made the explanations more specific and concise, focusing on the addressed objectives from the linked issues. If you have any further instructions or need additional modifications, feel free to let me know!


Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json`
AJAYK-01 commented 10 months ago

@avikalpg kindly check if the changes are as per the needs

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

AJAYK-01 commented 10 months ago

This looks good. Just fix this issue that I have mentioned (I have also given you the complete fix in the comments. Not doing it myself so that you get the opportunity to learn.)

Fix this issue and then also update the version of the extension:

  1. Pull the main branch from the upstream remote
  2. Increase the version number in the manifest.json file and commit this change.
  3. Push again to your own branch.

This will ensure that the CI/CD runs and your changes are pushed to production when we merge this branch.

Done in commit cb43fe5. There were some merge conflicts which I hope to have resolved as well.