Closed AJAYK-01 closed 10 months ago
Your content is well-structured and provides a clear overview of the changes made. However, I noticed that the "Assessment against linked issues" section could be improved to provide more specific and concise explanations. Below is the revised content based on your instructions:
The recent changes involve updating the functionality to display tracking indicators for repositories on GitHub. The updates allow the system to handle both user and organization pages by introducing a new parameter to distinguish between the two. The changes ensure that the tracking logo is appended to repositories that are being tracked, making it visible on the GitHub repositories page for both users and organizations.
File Path | Change Summary |
---|---|
scripts/orchestrator.js |
Added handling for query string tab=repositories to trigger tracking updates for GitHub user and organization pages. |
scripts/repoHandlers.js |
Introduced updateTrackedReposInUserGitHub and updated updateTrackedReposInGitHub to handle tracking indicators for both user and organization repositories on GitHub. |
Objective | Addressed | Explanation |
---|---|---|
Missing Vibinex logo for non-organization repository owners (68) | ❓ | The changes suggest that the functionality for displaying the logo was added or fixed, but without the previous state of the code or the specific issue details, it's unclear if the exact cause of the missing logo was identified. |
Vibinex logo visibility at specified URL pattern (68) | ✅ | The changes in orchestrator.js and repoHandlers.js are designed to address this issue by appending the tracking logo to the repositories list on the user's GitHub page when the URL matches the specified pattern. |
I've made the explanations more specific and concise, focusing on the addressed objectives from the linked issues. If you have any further instructions or need additional modifications, feel free to let me know!
@avikalpg kindly check if the changes are as per the needs
Kudos, SonarCloud Quality Gate passed!
This looks good. Just fix this issue that I have mentioned (I have also given you the complete fix in the comments. Not doing it myself so that you get the opportunity to learn.)
Fix this issue and then also update the version of the extension:
- Pull the
main
branch from the upstream remote- Increase the version number in the
manifest.json
file and commit this change.- Push again to your own branch.
This will ensure that the CI/CD runs and your changes are pushed to production when we merge this branch.
Done in commit cb43fe5. There were some merge conflicts which I hope to have resolved as well.
Fixes #68
The other issue addressed:
The Forked url was also being recognized by the extension if it has the same repo name, and the logo was being added. Fixed that too by only selecting the a href element with
itemprop="name codeRepository"
to indicate main repo urls.After Fix:
Summary by CodeRabbit
New Features
Refactor
Style