search

vibudh2209 / STAT545-hw-Agrawal-Vibudh

0 stars 0 forks source link

hw01 ready for grading #1

Open vibudh2209 opened 7 years ago

vibudh2209 commented 7 years ago

The link to Markdown file is this

@vincenzocoia @gvdr @ksedivyhaley @joeybernhardt @mynamedaike @pgonzaleze @derekcho

teilhard1976 commented 7 years ago

@vincenzocoia @gvdr @ksedivyhaley @JoeyBernhardt @mynamedaike @pgonzaleze @derekcho @vibudh2209

I appreciate the creativity that Agrawal Vibudh has shown in his Readme.md file. Starting with the gif of Tyron Lannister dancing is a fun way to begin his introductions. And I did get sense of who he is in the section on “A little something about me”. His description of his process could have been more elaborated. It is obvious that Agrawal Vibudh knows what he is doing. Because he has been able to execute the instructions of first homework efficiently and elegantly, and his repository has been organized cleanly. But perhaps he could have communicated his process thoroughly and reflexively for the sake of his readers. Moreover, a clearly structured Readme file would have been a bit more useful for us to follow. But these are minor quibbles in an otherwise successful first homework.

sevenelevenkevin commented 7 years ago

readme.md: -included multiple aspects of Markdown syntax, code was clear and easy to read -all links worked -included a general comment on how and where things were changed -logged reflections on working with Markdown and the homework in general
-maybe include a little comment on what was actually changed in each commit -overall an excellent job!

gapminder: -included functions on the gapminder dataset, code worked, style was clear and presentable -maybe include a few comments on what each function does -but again, overall, it was excellent

Kevin Zhu

derekcho commented 7 years ago

Hi @vibudh2209! Here are some comments about your hw01:

Great README.md file that looks very clean and uses many different markdown syntaxes! Your markdown file for the gapminder data looks tidy but it would have been nice if you had tried to do a few new things with the dataset. For example, try plotting new variables instead of the same ones as the example in class. Good work overall!

Note: your mark (check minus, check, check plus) will be distributed later.