vibudh2209 / STAT547M-hw-Agrawal-Vibudh

0 stars 1 forks source link

hw02 ready for grading #2

Open vibudh2209 opened 6 years ago

vibudh2209 commented 6 years ago

The link to mark down file

The link to makefile

The link to Masterfile

The link to cleanerfile

The link to Readmefile

heathersummers commented 6 years ago

Hi Vibudh,

Overall, great work on this assignment, you included all the necessary components. I would suggest trying to clean up the all the files in your hw02 folder by including separate folders for data and figures. For the first section of the assignment you included descriptive plots of year vs. life expectancy weighted by population for all the continents and then reordered the continents by average population and life expectancy and created figures for before and after reordering which made it easy to see how the data changed. For the second section of the assignment you fit a linear regression model to life expectancy vs. year data for each country, it was great to see you used the package broom. The figures for the three worst countries in both Asia and Africa based on maximum standard error were easy to understand and contained the required components (i.e. facetted by country, fitted line overlaid, etc.) however, I would suggest adding detailed titles for each of the graphs. For the final section of the assignment on automating the pipeline you did so with Makefile and included a very detailed description of how the pipeline works in in your README.md file! Something I did not do was make a graphical view of my pipeline so I found it particularly interesting to see yours. Good reflection on your process and it is great to hear you feel you have a good grasp of how to use Makefile. Best of luck on future assignments.

Heather

derekcho commented 6 years ago

Hi @vibudh2209 ! Here are some comments about your hw07: Three or more scripts, an Rmd, and a Makefile: No (see comments) Starts by downloading data, ends with Rmd: No (see comments) The output of each is the modified input of the previous step: Yes Includes some analysis and at least one figure: Yes Makefile includes all scripts and Rmd with correct dependencies: No (see comments) Makefile runs: Yes

Note: your mark (check minus, check, check plus) will be distributed later.