search

vic / apollo-phoenix-websocket

An Apollo networkInterface for executing GraphQL queries via Phoenix Channels
Apache License 2.0
91 stars 9 forks source link

Include `Socket` from Phoenix framework npm module. #4

Closed conor-mac-aoidh closed 7 years ago

conor-mac-aoidh commented 7 years ago

Just a small optimisation, to include the phoenix Socket class from the phoenix framework module instead of including the source in this module.

vic commented 7 years ago

Oh nice didnt know of that module. Could you fix the README that currently mentions the bundled phoenix.js ? Also, maybe it'd be nice to state that for people using this library from a phoenix project itself, they might prefer to use the generated web/static/js/socket.js, then they'd need to require it and pass its Socket impl as an option to createNetworkInterface.

Thank you :)

conor-mac-aoidh commented 7 years ago

@vic I've updated the readme and you can view it here.

vic commented 7 years ago

Merged, Thanks!