search

vic778 / school-library-

A console app that will help you to keep a record of different types of things you won: books, music albums, movies, and games
1 stars 0 forks source link

# Team members #5

Open vic778 opened 2 years ago

vic778 commented 2 years ago

we are two in this project https://github.com/vic778/ruby_capstone/projects/1

dasileker commented 2 years ago

Hi @chukwuemeka1234,

Good job so far!

There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Check the comments under the review.

Capture web_28-3-2022_1151_github com

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Dipeshtwis commented 2 years ago

Hi @chukwuemeka1234 & @vic778,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Required Changes ♻️

Screenshot from 2022-03-28 17-10-39

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

TedLivist commented 2 years ago

STATUS: APPROVED ✔️ ✔️

Hi @chukwuemeka1234 and @vic778,

Your project is complete! There is nothing else to say other than... it's time to go ahead :shipit: Congratulations! 🎉

OPTIONAL SUGGESTION

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.