vicb / VisuGps3

Display GPS tracks on top of Google maps
MIT License
36 stars 13 forks source link

missing dependency : six #12

Open oupala opened 7 years ago

oupala commented 7 years ago

While trying to make lint, I get an ImportError: No module named six.

Si I added the missing dependency:

pip install six

It does now go further.

oupala commented 7 years ago

With the dependency installed, I still get an error in the end:

Found 255 errors, including 0 new errors, in 24 files (14 files OK). [...] Makefile:10 : la recette pour la cible « lint » a échouée make: *** [lint] Erreur 1

vicb commented 7 years ago

see https://developers.google.com/closure/utilities/docs/linter_howto

what happens if you try to invoke gjslint on the CLI ?

oupala commented 7 years ago

The linter invoked without any code answer an informational message:

$ gjslint 
0 files checked, no errors found.

When launched with the js files, I get the following stdout:

$ gjslint $(find src -name \*.js) --jslinterror well_formed_author --jslinterror no_braces_around_inherit_doc --jslinterror braces_around_type --jslinterror optional_type_marker --jslinterror unused_private_members

----- FILE  :  VisuGps3/src/vgps3/loader/loader.js -----
Line 72, E:0110: Line too long (81 characters).
Line 74, E:0110: Line too long (89 characters).
Line 77, E:0110: Line too long (84 characters).
Line 85, E:0110: Line too long (88 characters).
Line 87, E:0110: Line too long (113 characters).
Line 90, E:0110: Line too long (101 characters).
Line 95, E:0110: Line too long (94 characters).
Line 101, E:0110: Line too long (114 characters).
Line 108, E:0110: Line too long (86 characters).
Line 109, E:0110: Line too long (98 characters).
Line 118, E:0110: Line too long (81 characters).
Line 126, E:0110: Line too long (106 characters).
Line 131, E:0110: Line too long (89 characters).
Line 146, E:0110: Line too long (89 characters).
Line 167, E:0214: Missing description in @define tag
----- FILE  :  VisuGps3/src/vgps3/plugins/airspace/airspace.js -----
Line 93, E:0110: Line too long (96 characters).
Line 104, E:0110: Line too long (81 characters).
Line 132, E:0110: Line too long (100 characters).
Line 167, E:0110: Line too long (104 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/chart/chart.js -----
Line 131, E:0110: Line too long (102 characters).
Line 239, E:0110: Line too long (93 characters).
Line 241, E:0110: Line too long (84 characters).
Line 323, E:0110: Line too long (103 characters).
Line 341, E:0110: Line too long (92 characters).
Line 342, E:0110: Line too long (84 characters).
Line 343, E:0110: Line too long (83 characters).
Line 348, E:0110: Line too long (97 characters).
Line 379, E:0110: Line too long (86 characters).
Line 383, E:0110: Line too long (96 characters).
Line 411, E:0110: Line too long (81 characters).
Line 525, E:0110: Line too long (82 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/chart/externs/google_viz_api_v1.0.js -----
Line 28, E:0110: Line too long (81 characters).
Line 308, E:0110: Line too long (81 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/chart/sliders.js -----
Line 47, E:0110: Line too long (93 characters).
Line 62, E:0110: Line too long (111 characters).
Line 63, E:0110: Line too long (110 characters).
Line 127, E:0214: Missing description in @define tag
Line 130, E:0110: Line too long (91 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/doarama/doarama.js -----
Line 184, E:0110: Line too long (94 characters).
Line 185, E:0110: Line too long (85 characters).
Line 202, E:0110: Line too long (111 characters).
Line 204, E:0110: Line too long (85 characters).
Line 223, E:0110: Line too long (97 characters).
Line 256, E:0110: Line too long (115 characters).
Line 267, E:0110: Line too long (93 characters).
Line 285, E:0110: Line too long (89 characters).
Line 286, E:0110: Line too long (114 characters).
Line 291, E:0110: Line too long (100 characters).
Line 294, E:0110: Line too long (102 characters).
Line 321, E:0110: Line too long (86 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/earth/earth.js -----
Line 15, E:0110: Line too long (85 characters).
Line 104, E:0110: Line too long (85 characters).
Line 152, E:0110: Line too long (91 characters).
Line 217, E:0110: Line too long (105 characters).
Line 220, E:0110: Line too long (116 characters).
Line 253, E:0110: Line too long (97 characters).
Line 261, E:0110: Line too long (89 characters).
Line 264, E:0110: Line too long (93 characters).
Line 266, E:0110: Line too long (96 characters).
Line 267, E:0110: Line too long (81 characters).
Line 270, E:0110: Line too long (95 characters).
Line 275, E:0110: Line too long (97 characters).
Line 290, E:0110: Line too long (82 characters).
Line 324, E:0110: Line too long (88 characters).
Line 330, E:0110: Line too long (88 characters).
Line 331, E:0110: Line too long (105 characters).
Line 342, E:0110: Line too long (107 characters).
Line 349, E:0110: Line too long (82 characters).
Line 350, E:0110: Line too long (89 characters).
Line 354, E:0110: Line too long (102 characters).
Line 357, E:0110: Line too long (91 characters).
Line 365, E:0110: Line too long (91 characters).
Line 385, E:0110: Line too long (81 characters).
Line 429, E:0110: Line too long (113 characters).
Line 437, E:0110: Line too long (82 characters).
Line 451, E:0110: Line too long (82 characters).
Line 474, E:0110: Line too long (92 characters).
Line 517, E:0110: Line too long (83 characters).
Line 521, E:0110: Line too long (95 characters).
Line 541, E:0110: Line too long (85 characters).
Line 544, E:0110: Line too long (115 characters).
Line 567, E:0110: Line too long (84 characters).
Line 571, E:0110: Line too long (101 characters).
Line 584, E:0110: Line too long (86 characters).
Line 604, E:0110: Line too long (81 characters).
Line 610, E:0110: Line too long (81 characters).
Line 613, E:0110: Line too long (89 characters).
Line 614, E:0110: Line too long (120 characters).
Line 627, E:0214: Missing description in @define tag
Line 633, E:0214: Missing description in @define tag
----- FILE  :  VisuGps3/src/vgps3/plugins/earth/externs/google_earth_api.js -----
Line 45, E:0110: Line too long (95 characters).
Line 55, E:0110: Line too long (101 characters).
Line 65, E:0110: Line too long (104 characters).
Line 1275, E:0110: Line too long (126 characters).
Line 1590, E:0110: Line too long (84 characters).
Line 1730, E:0110: Line too long (81 characters).
Line 1737, E:0110: Line too long (81 characters).
Line 1785, E:0110: Line too long (85 characters).
Line 1910, E:0110: Line too long (93 characters).
Line 2101, E:0110: Line too long (103 characters).
Line 2350, E:0110: Line too long (83 characters).
Line 2358, E:0110: Line too long (86 characters).
Line 2384, E:0110: Line too long (89 characters).
Line 2505, E:0110: Line too long (84 characters).
Line 2723, E:0110: Line too long (105 characters).
Line 2820, E:0110: Line too long (104 characters).
Line 2909, E:0110: Line too long (92 characters).
Line 2915, E:0110: Line too long (94 characters).
Line 2921, E:0110: Line too long (88 characters).
Line 2945, E:0110: Line too long (84 characters).
Line 2951, E:0110: Line too long (82 characters).
Line 2957, E:0110: Line too long (82 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/fullscreen/fullscreen.js -----
Line 140, E:0110: Line too long (93 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/path/path.js -----
Line 77, E:0110: Line too long (88 characters).
Line 127, E:0110: Line too long (112 characters).
Line 137, E:0110: Line too long (81 characters).
Line 165, E:0110: Line too long (95 characters).
Line 187, E:0110: Line too long (104 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/route/route.js -----
Line 56, E:0110: Line too long (95 characters).
Line 124, E:0110: Line too long (90 characters).
Line 176, E:0110: Line too long (88 characters).
Line 182, E:0110: Line too long (84 characters).
Line 188, E:0110: Line too long (83 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/skyways/skyways.js -----
Line 84, E:0110: Line too long (83 characters).
Line 173, E:0110: Line too long (86 characters).
Line 198, E:0110: Line too long (115 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/topo/abstracttopo.js -----
Line 65, E:0221: Member "vgps3.topo.AbstractTopo.prototype.setBounds_" must have @private JsDoc.
Line 92, E:0221: Member "vgps3.topo.AbstractTopo.prototype.setCopyright_" must have @private JsDoc.
Line 99, E:0110: Line too long (86 characters).
Line 112, E:0221: Member "vgps3.topo.AbstractTopo.prototype.registerMapType_" must have @private JsDoc.
Line 128, E:0221: Member "vgps3.topo.AbstractTopo.prototype.showHandler_" must have @private JsDoc.
Line 138, E:0221: Member "vgps3.topo.AbstractTopo.prototype.hideHandler_" must have @private JsDoc.
Line 153, E:0221: Member "vgps3.topo.AbstractTopo.prototype.isTileVisible_" must have @private JsDoc.
Line 193, E:0221: Member "vgps3.topo.AbstractTopo.prototype.getMapType_" must have @private JsDoc.
Line 205, E:0221: Member "vgps3.topo.AbstractTopo.prototype.getTileUrl_" must have @private JsDoc.
----- FILE  :  VisuGps3/src/vgps3/plugins/topo/ch.js -----
Line 73, E:0110: Line too long (89 characters).
Line 84, E:0223: vgps3.topo.ch.Map.prototype.showHandler_ should not override a private member.
Line 86, E:0221: Member "vgps3.topo.ch.Map.prototype.showHandler_" must have @private JsDoc.
Line 98, E:0223: vgps3.topo.ch.Map.prototype.hideHandler_ should not override a private member.
Line 100, E:0221: Member "vgps3.topo.ch.Map.prototype.hideHandler_" must have @private JsDoc.
Line 128, E:0223: vgps3.topo.ch.Map.prototype.getMapType_ should not override a private member.
Line 130, E:0221: Member "vgps3.topo.ch.Map.prototype.getMapType_" must have @private JsDoc.
Line 148, E:0223: vgps3.topo.ch.Map.prototype.getTileUrl_ should not override a private member.
Line 150, E:0221: Member "vgps3.topo.ch.Map.prototype.getTileUrl_" must have @private JsDoc.
Line 161, E:0110: Line too long (86 characters).
Line 170, E:0110: Line too long (117 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/topo/es.js -----
Line 72, E:0223: vgps3.topo.es.Map.prototype.showHandler_ should not override a private member.
Line 74, E:0221: Member "vgps3.topo.es.Map.prototype.showHandler_" must have @private JsDoc.
Line 93, E:0223: vgps3.topo.es.Map.prototype.hideHandler_ should not override a private member.
Line 95, E:0221: Member "vgps3.topo.es.Map.prototype.hideHandler_" must have @private JsDoc.
Line 135, E:0223: vgps3.topo.es.Map.prototype.getMapType_ should not override a private member.
Line 137, E:0221: Member "vgps3.topo.es.Map.prototype.getMapType_" must have @private JsDoc.
Line 147, E:0110: Line too long (109 characters).
Line 154, E:0223: vgps3.topo.es.Map.prototype.getTileUrl_ should not override a private member.
Line 156, E:0221: Member "vgps3.topo.es.Map.prototype.getTileUrl_" must have @private JsDoc.
Line 166, E:0110: Line too long (99 characters).
Line 178, E:0221: Member "vgps3.topo.es.Map.prototype.getLayerName_" must have @private JsDoc.
Line 195, E:0110: Line too long (117 characters).
Line 211, E:0110: Line too long (87 characters).
Line 216, E:0110: Line too long (94 characters).
Line 218, E:0110: Line too long (98 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/topo/eu.js -----
Line 48, E:0223: vgps3.topo.eu.Map.prototype.getMapType_ should not override a private member.
Line 50, E:0221: Member "vgps3.topo.eu.Map.prototype.getMapType_" must have @private JsDoc.
Line 63, E:0223: vgps3.topo.eu.Map.prototype.getTileUrl_ should not override a private member.
Line 65, E:0221: Member "vgps3.topo.eu.Map.prototype.getTileUrl_" must have @private JsDoc.
----- FILE  :  VisuGps3/src/vgps3/plugins/topo/fr.js -----
Line 67, E:0110: Line too long (90 characters).
Line 72, E:0223: vgps3.topo.fr.Map.prototype.getMapType_ should not override a private member.
Line 74, E:0221: Member "vgps3.topo.fr.Map.prototype.getMapType_" must have @private JsDoc.
Line 87, E:0223: vgps3.topo.fr.Map.prototype.getTileUrl_ should not override a private member.
Line 89, E:0221: Member "vgps3.topo.fr.Map.prototype.getTileUrl_" must have @private JsDoc.
Line 99, E:0110: Line too long (81 characters).
Line 104, E:0110: Line too long (89 characters).
Line 113, E:0110: Line too long (224 characters).
----- FILE  :  VisuGps3/src/vgps3/plugins/track/track.js -----
Line 84, E:0110: Line too long (82 characters).
Line 117, E:0110: Line too long (90 characters).
Line 139, E:0110: Line too long (119 characters).
Line 160, E:0110: Line too long (87 characters).
Line 163, E:0110: Line too long (106 characters).
Line 175, E:0110: Line too long (88 characters).
Line 219, E:0110: Line too long (82 characters).
Line 233, E:0110: Line too long (92 characters).
Line 245, E:0210: Missing docs for parameter: "trackIndex"
Line 300, E:0110: Line too long (81 characters).
Line 301, E:0110: Line too long (81 characters).
Line 306, E:0110: Line too long (101 characters).
Line 312, E:0110: Line too long (88 characters).
Line 318, E:0110: Line too long (94 characters).
Line 331, E:0110: Line too long (92 characters).
Line 332, E:0110: Line too long (84 characters).
Line 333, E:0110: Line too long (90 characters).
Line 358, E:0110: Line too long (106 characters).
Line 366, E:0110: Line too long (92 characters).
Line 382, E:0110: Line too long (90 characters).
Line 390, E:0110: Line too long (92 characters).
Line 391, E:0110: Line too long (89 characters).
Line 403, E:0110: Line too long (95 characters).
Line 401, E:0217: Missing @return JsDoc in function with non-trivial return
Line 462, E:0110: Line too long (92 characters).
Line 469, E:0110: Line too long (109 characters).
Line 473, E:0110: Line too long (87 characters).
Line 475, E:0110: Line too long (105 characters).
Line 503, E:0110: Line too long (83 characters).
Line 505, E:0110: Line too long (110 characters).
Line 513, E:0110: Line too long (91 characters).
Line 527, E:0110: Line too long (82 characters).
Line 575, E:0110: Line too long (121 characters).
Line 579, E:0110: Line too long (85 characters).
----- FILE  :  VisuGps3/src/vgps3/proj/gproj.js -----
Line 24, E:0110: Line too long (86 characters).
Line 97, E:0110: Line too long (102 characters).
Line 98, E:0110: Line too long (102 characters).
----- FILE  :  VisuGps3/src/vgps3/proj/iberpix.js -----
Line 47, E:0213: Missing type in @param tag
----- FILE  :  VisuGps3/src/vgps3/proj/swisstopo.js -----
Line 43, E:0110: Line too long (93 characters).
Line 44, E:0110: Line too long (104 characters).
Line 62, E:0110: Line too long (112 characters).
Line 63, E:0110: Line too long (97 characters).
----- FILE  :  VisuGps3/src/vgps3/proj/transversemercator.js -----
Line 27, E:0110: Line too long (108 characters).
Line 32, E:0110: Line too long (88 characters).
Line 35, E:0110: Line too long (99 characters).
Line 36, E:0110: Line too long (89 characters).
Line 37, E:0110: Line too long (92 characters).
Line 41, E:0110: Line too long (100 characters).
Line 42, E:0110: Line too long (104 characters).
Line 91, E:0110: Line too long (148 characters).
Line 92, E:0110: Line too long (210 characters).
Line 103, E:0110: Line too long (91 characters).
Line 104, E:0110: Line too long (253 characters).
Line 108, E:0110: Line too long (100 characters).
Line 110, E:0110: Line too long (234 characters).
Line 111, E:0110: Line too long (184 characters).
Line 135, E:0110: Line too long (82 characters).
Line 136, E:0110: Line too long (230 characters).
----- FILE  :  VisuGps3/src/vgps3/vgps3.js -----
Line 32, E:0110: Line too long (87 characters).
Line 105, E:0110: Line too long (89 characters).
Line 177, E:0110: Line too long (81 characters).
Line 186, E:0110: Line too long (90 characters).
Line 205, E:0110: Line too long (89 characters).
Line 211, E:0214: Missing description in @define tag
----- FILE  :  VisuGps3/src/vgps3/viewer.js -----
Line 128, E:0110: Line too long (100 characters).
Line 129, E:0110: Line too long (113 characters).
Line 130, E:0110: Line too long (140 characters).
Line 132, E:0110: Line too long (100 characters).
Line 145, E:0110: Line too long (81 characters).
Line 193, E:0110: Line too long (113 characters).
Line 197, E:0110: Line too long (103 characters).
Line 198, E:0110: Line too long (99 characters).
Line 214, E:0110: Line too long (110 characters).
Line 217, E:0220: No docs found for member 'vgps3.Viewer.prototype.setupFileDrop_'
Line 221, E:0110: Line too long (87 characters).
Line 232, E:0110: Line too long (86 characters).
Found 249 errors, including 0 new errors, in 24 files (14 files OK).

Some of the errors reported by GJsLint may be auto-fixable using the script
fixjsstyle. Please double check any changes it makes and report any bugs. The
script can be run by executing:

fixjsstyle src/vgps3/viewer.js src/vgps3/pluginbase.js src/vgps3/plugins/fullscreen/fullscreen.js src/vgps3/plugins/chart/moveevent.js src/vgps3/plugins/chart/sliders.js src/vgps3/plugins/chart/chart.js src/vgps3/plugins/chart/aboutevent.js src/vgps3/plugins/chart/externs/google_viz_api_v1.0.js src/vgps3/plugins/chart/wheelevent.js src/vgps3/plugins/chart/clickevent.js src/vgps3/plugins/chart/overlays.js src/vgps3/plugins/track/updateevent.js src/vgps3/plugins/track/track.js src/vgps3/plugins/track/trackSelectEvent.js src/vgps3/plugins/track/loadevent.js src/vgps3/plugins/track/clickevent.js src/vgps3/plugins/path/path.js src/vgps3/plugins/route/route.js src/vgps3/plugins/earth/externs/google_earth_api.js src/vgps3/plugins/earth/earth.js src/vgps3/plugins/earth/clickevent.js src/vgps3/plugins/topo/eu.js src/vgps3/plugins/topo/fr.js src/vgps3/plugins/topo/abstracttopo.js src/vgps3/plugins/topo/es.js src/vgps3/plugins/topo/ch.js src/vgps3/plugins/airspace/airspace.js src/vgps3/plugins/doarama/doarama.js src/vgps3/plugins/skyways/skyways.js src/vgps3/control.js src/vgps3/vgps3.js src/vgps3/loader/loader.js src/vgps3/loader/loadmask.js src/vgps3/proj/iberpix.js src/vgps3/proj/transversemercator.js src/vgps3/proj/gproj.js src/vgps3/proj/iproj.js src/vgps3/proj/swisstopo.js --jslinterror well_formed_author --jslinterror no_braces_around_inherit_doc --jslinterror braces_around_type --jslinterror optional_type_marker --jslinterror unused_private_members