search

vicb / flyXC

One stop shop web app for paraglider pilots. Plan, visualize, and track your flights.
https://flyxc.app
MIT License
96 stars 34 forks source link

Minor PWA tweaks #242

Closed vicb closed 4 months ago

vicb commented 4 months ago

Summary by Sourcery

This pull request includes minor tweaks to the Progressive Web App (PWA) configuration. It enhances the service worker script by renaming a function for clarity and adding caching for Google Fonts. Additionally, it updates the PWA configuration to include icons for the 3D view.

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

The recent updates enhance the Progressive Web App (PWA) configuration and service worker scripts in the apps/fxc-front directory. Notably, the PWA configuration now supports additional icon settings for a 3D view feature, while the service worker optimizes asset caching by including Google Fonts and refining asset cache functions.

Changes

Files Change Summary
apps/fxc-front/pwa.config.ts Added icons configuration for 3D view feature.
apps/fxc-front/src/sw.ts Updated asset cache strategy, added Google Fonts caching, renamed function to isCacheableAsset, and set default handler to NetworkOnly.

Sequence Diagram(s)

sequenceDiagram
    participant App as PWA App
    participant browser as Browser
    participant SW as Service Worker
    participant GoogleFonts as Google Fonts Cache

    Note over App, SW: Icon Configuration Update
    App->>browser: PWA Configuration with 3D Icons

    Note over SW: Google's Font Caching
    browser->>SW: Fetch Google Fonts
    SW->>GoogleFonts: Cache Fonts
    GoogleFonts-->>SW: Fonts Cached
    SW-->>browser: Serve Cached Fonts

    Note over SW: Updated Cache Strategy
    browser->>SW: Fetch Cacheable Asset
    SW->>browser: Serve Cached Asset
    browser->>SW: Fetch Network Only Asset
    SW->>browser: Network Only

Poem

In the code where changes crawl,
Icons bloom with views in 3D thrall, 🎨
Google Fonts now swift in flight, 🚀
Cached with care, pristine and bright.
Code evolves in rhythmic flair,
Bugs beware, the rabbit’s there! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request introduces minor tweaks to the Progressive Web App (PWA) configuration and service worker script. The changes include adding caching for Google Fonts, renaming a function for clarity, and updating the PWA configuration to include new icons for the 3D view.

File-Level Changes

Files Changes
apps/fxc-front/src/sw.ts
apps/fxc-front/pwa.config.ts		 Enhanced PWA capabilities by caching Google Fonts and adding new icons for the 3D view.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying flyxc with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee4d4eb
Status: ✅  Deploy successful!
Preview URL: https://3a40241b.flyxc.pages.dev
Branch Preview URL: https://pwa-plus.flyxc.pages.dev

View logs