search

vicb / flyXC

One stop shop web app for paraglider pilots. Plan, visualize, and track your flights.
https://flyxc.app
MIT License
97 stars 34 forks source link

Add an option to get 48h of live data history #269

Closed vicb closed 4 months ago

vicb commented 4 months ago

Summary by Sourcery

This pull request adds support for retrieving 48 hours of live data history, refactors live data retention and interval constants into enums, and updates the logic for handling live track data to support multiple retention periods. Additionally, the privacy policy has been updated to reflect the new data retention period.

Summary by CodeRabbit

sourcery-ai[bot] commented 4 months ago

Reviewer's Guide by Sourcery

This pull request introduces support for fetching and displaying 48-hour live data history. The changes include refactoring the fetcher logic to handle different time ranges, updating API endpoints, and modifying frontend components to support the new data retention periods. Additionally, enums for data retention and interval constants were introduced for better maintainability.

File-Level Changes

Files Changes
apps/fetcher/src/fetcher.ts
apps/fetcher/src/app/trackers/refresh.ts
apps/fetcher/src/app/ufos/refresh.ts		 Refactored fetcher logic to support 12h, 24h, and 48h data retention, including new helper functions and updated pipeline commands.
libs/common/src/lib/live-track.ts
libs/common/src/lib/redis-keys.ts		 Introduced enums for data retention and interval constants, and updated Redis keys to reflect new data retention periods.
apps/fxc-server/src/app/routes/live-track.ts
apps/fxc-front/src/app/redux/live-track-slice.ts
apps/fxc-front/src/app/components/ui/main-menu.ts		 Updated API and frontend logic to support fetching and displaying 48-hour live data history.
apps/fetcher/src/app/trackers/inreach.ts
apps/fetcher/src/app/trackers/skylines.ts
apps/fetcher/src/app/trackers/flymaster.ts
apps/fetcher/src/app/trackers/spot.ts		 Replaced old interval constants with new LiveDataIntervalSec enum for consistency.
apps/fxc-front/src/app/pages/admin.ts
apps/fxc-server/src/app/routes/admin.ts		 Updated admin pages to use new keys for full and incremental track counts.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
coderabbitai[bot] commented 4 months ago

Walkthrough

The updates introduce changes across multiple files, primarily involving renaming constants and restructuring code for better clarity and organization. Key constants related to time intervals and retention periods in live tracking have been refactored into enums, and function parameters have been updated accordingly. These modifications also improve error handling, logging mechanisms, and streamline the overall logic in the fetching and processing of live tracker data.

Changes

Files Change Summary
.../flymaster.ts, .../inreach.ts, .../skylines.ts, .../spot.ts, .../tracker.ts, .../xcontest.ts, .../refresh.ts, .../live-track.ts Replaced the constant LIVE_MINIMAL_INTERVAL_SEC with LiveDataIntervalSec.Recent in simplifyLiveTrack function calls.
.../refresh.ts, .../ufos/refresh.ts Renamed variables related to live data intervals and retention periods, updated assignments, and adjusted function calls.
.../fetcher.ts Removed references to old constants, introduced LiveDataRetentionSec, reorganized track processing logic, and added a new function maybePushTrack.
.../main-menu.ts, .../supporter-modal.ts Added a new <ion-select> option for 48 hours, and updated the hosting cost text.
.../admin.ts, .../privacy-policy.ts Updated keys and renamed constants related to track display durations.
.../live-track-slice.ts Updated updateTrackers function to include fetchMin calculation and use it in the fetch URL.
.../redis-keys.ts Reorganized live track keys in Redis and updated naming conventions for clarity.
.../live-track.ts Reorganized constants to enums for better clarity in defining data retention and intervals.

Poem

In the code where data flows, Constants shift, and clarity grows, For live tracks new enums rise, Simplified in coder’s eyes.

Forty-eight hours now we see, Improved the flow, refined with glee. 🐇✨🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying flyxc with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3cecaba
Status: ✅  Deploy successful!
Preview URL: https://4a138e5c.flyxc.pages.dev
Branch Preview URL: https://h48.flyxc.pages.dev

View logs