Closed vicb closed 1 week ago
This pull request fixes an issue where the Bircom route was not properly returning a 200 status code. The change involves a minor modification to the response handling in the getMeshBirRouter function.
Change | Details | Files |
---|---|---|
Fixed the HTTP response for successful requests in the Bircom route |
|
apps/fxc-server/src/app/routes/meshbir.ts |
The changes involve modifications to the getMeshBirRouter
function in the meshbir.ts
file, specifically updating the response handling method. Additionally, the package.json
file has been altered to adjust the scripts for development, checking, and linting processes, including changes to parallel execution counts and the addition of a build step for secrets.
File | Change Summary |
---|---|
apps/.../meshbir.ts | Updated response handling in getMeshBirRouter from res.status(200) to res.sendStatus(200) . |
package.json | Modified scripts: updated "dev" to include nx build secrets , reduced parallel count in "check" and "fixlint" from 8 to 6. |
sequenceDiagram
participant Client
participant Server
Client->>Server: Request for MeshBir
Server->>Server: Process request
Server-->>Client: Send status 200 (using sendStatus)
🐰 In the meadow where I hop and play,
Changes come to brighten the day.
Scripts now dance with a lighter load,
Responses sing in a clearer code.
Hooray for secrets, oh what a treat,
My little heart skips a joyful beat! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
And minor tweaks
Summary by Sourcery
Fix the Bircom route to ensure it returns a 200 status code by using the correct method.
Bug Fixes:
Summary by CodeRabbit
New Features
Chores