search

vicb / flyXC

One stop shop web app for paraglider pilots. Plan, visualize, and track your flights.
https://flyxc.app
MIT License
91 stars 34 forks source link

Fix Bircom messages #310

Closed vicb closed 1 week ago

vicb commented 1 week ago

Correctly look for the last known position

Summary by Sourcery

Fix the message association logic to correctly use the last known position by referencing the most recent timestamp in the track data, and update the corresponding test cases to validate this behavior.

Bug Fixes:

Tests:

Summary by CodeRabbit

sourcery-ai[bot] commented 1 week ago

Reviewer's Guide by Sourcery

This pull request fixes an issue with Bircom messages by correctly looking for the last known position. The changes involve updating the test case and the main implementation to use the most recent position data instead of the first one.

File-Level Changes

Change Details Files
Update test case to use more recent timestamps and multiple position entries
  • Change timestamps from 123xxx to 234xxx
  • Update mock track data to include multiple entries for alt, lat, lon, and timeSec
  • Adjust expected output to use the last (most recent) position data
 apps/fetcher/src/app/trackers/meshbir.test.ts
Modify implementation to use the last known position instead of the first one
  • Replace track.timeSec[0] with track.timeSec.at(-1) to get the last timestamp
 apps/fetcher/src/app/trackers/meshbir.ts
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
coderabbitai[bot] commented 1 week ago

Walkthrough

The changes involve updates to the test cases for the parse function in the meshbir.test.ts file, including adjustments to simulated timer values and test data structures. The parse function in meshbir.ts has been modified to calculate lastFixAgeSec using the last element of the track.timeSec array instead of the first, altering the logic for determining the age of the last fix.

Changes

Files Change Summary
apps/fetcher/src/app/trackers/meshbir.test.ts, apps/fetcher/src/app/trackers/meshbir.ts Updates to test cases and the parse function logic, including changes to timer values, message properties, and the calculation of lastFixAgeSec.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test Suite
    participant Parser as parse function
    participant Data as Data Structure

    Test->>Data: Initialize test data with new values
    Test->>Parser: Call parse with updated data
    Parser->>Parser: Calculate lastFixAgeSec using last element of timeSec
    Parser-->>Test: Return parsed results

Poem

🐇 In a meadow where time does dance,
I hop with joy, a happy glance.
With data fresh and tests anew,
The parse function sings a tune!
Hooray for changes, bright and spry,
Let’s leap and bound, oh me, oh my! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
vicb commented 1 week ago

/cc @ketan @cyberorg