Closed johnmarkredding closed 3 months ago
Thank you so much @johnmarkredding ! I'll review the PR tomorrow CET
Thanks @johnmarkredding, the PR looks great.
I'll merge it next week when I'm back home - do not worry about the conflicting npm-shrinkwrap.json
, I'll re-generate this one after the commits are merged.
I have just merged the PR, thanks!
Switched from redux
createStore
to rtkconfigureStore
. Exported custom store type (AppStore
) to include strong typing for the specifics of our state.I want to have this pulled to see if we're on the right track, and this will play nicely before moving on.
The next steps I see are using
slices
instead of actions/reducers explicitly, but that will take more time as there are some expections to the normal action and reducer patterns I see. Ex: 'cancelSubscriptions' doesn't belong to a reducer in the way that the other actions do. Also the functionscomputeForecasts
andforecasts
in the reducer forsounding.ts
don't fit super nicely into the slice pattern, but we can make that work fine, if we want to go with slices.