vicelab / cen-sierra-pywr

Code base for modeling the central Sierra Nevada hydropower systems
4 stars 7 forks source link

IFR below NF Stanislaus Div Res ("Below Utica Div") schematic and logic #19

Open alanccai opened 5 years ago

alanccai commented 5 years ago

According to the USGS schematic, this IFR, named "Below Utica Div" in OpenAgua, should be more accurately called "Below North Fork Stanislaus River Diversion Tunnel" or "Below NF Stanislaus River Diversion Reservoir"? Otherwise, looks good.

alanccai commented 5 years ago

(Looks good in terms of placement)

drheinheimer commented 5 years ago

In addition, the actual IFR is incorrect. From Gustavo:

below North Fork (Utica) Diversion Dam -> it is set as 5 cfs, but the documents says 16.5 cfs

Thanks Gustavo. I'll fix this.

drheinheimer commented 5 years ago

Fyi, I updated this area as: image

drheinheimer commented 5 years ago

Per Gustavo, I've fixed the IFR amount: image

alanccai commented 5 years ago

The language says:

Article 37. The Licensee shall release a continuous minimum flow of 16.5 cfs immediately below Spicer Meadow Dam and belowMcKays Diversion Dam and a flow of 16.5 cfs or the natural inflow,if less, below the North Fork Diversion Dam and below Beaver Creek Diversion Dam,

Here is the pseudo-code from my IFR doc:

If natural inflows into North Fork Diversion Dam< 16.5 Natural Inflows into North Fork Diversion Dam Elseif Natural inflows into North Fork Diversion Dam >=16.5 16.5

alanccai commented 5 years ago

Are we ignoring the language about "or the natural inflow, if less"? And sticking with single numbers There are many IFRs that have this.

drheinheimer commented 4 years ago

@alanccai Thanks. We are not ignoring the natural inflow part. However, we do not need to explicitly add it to the model. If there's not enough inflow, of course it won't be released. I can show several examples of this in the model.

drheinheimer commented 4 years ago

Need to implement ramping rate per #43. However, I think this is a low priority, since there are no hydropeaking facilities between Utica & New Spicer Meadow, and there is now a ramping rate constraint below NF Stanislaus Div Res