search

vicelab / cen-sierra-pywr

Code base for modeling the central Sierra Nevada hydropower systems
4 stars 7 forks source link

need to check that appropriate WYTs are applied to IFRs #64

Closed drheinheimer closed 4 years ago

drheinheimer commented 4 years ago

Right now, most, if not all, IFRs use the SJVI for WYTs. I don't think this is appropriate; need to check & update as needed.

alanccai commented 4 years ago

Gustavo and I have updated the google sheet with all the parameters you might need to create site-specific WYT classification methods:

  1. Water Year Type classification - Based on inflows at what location?
  2. Water Year Type classification - what month(s) are the forecast(s) made?
  3. Who is making the forecast - Bureau of Reclamation, CA Department of Water Resources, or Other?
  4. Is the forecast made of April-July runoff or the annual runoff? Or other?
  5. Once the forecast is made, how long is it valid for?

Note the unusually complex method for Friant Dam. Also note the license documents' lack of specification of some of these attributes in some cases. We will leave it up to you to choose a method in those cases.

asood12 commented 4 years ago

For Stanislaus: Below Donnells, Below Sand Bar, Below Philadelphia Diversion, Below Relief Res, Below Pinecrest Lake, and Below Sand Bar use the following for WYT:

Water Year Type DWR Forecast Annual Unimpaired Inflow to New Melones Reservoir (acre-feet)
Critically Dry Less than or equal to 350,000
Dry Greater than 350,000 and less than or equal to 676,000
Normal Greater than 676,000 and less than 1,585,000
Normal-Dry Greater than 676,000 and less than 1,050,000
Normal-Wet Greater than or equal to 1,050,000 and less than 1,585,000
Wet Greater than or equal to 1,585,000

Created a csv file - "stanislaus_WYT.csv", which gives WYT: 1 - Critically dry, 2 - Dry, 3 - Normal Dry, 4 - Normal Wet, 5 - Wet

alanccai commented 4 years ago

Stanislaus WYT Classification CSV files.zip

Stanislaus.River.WYT.classification.parameters.docx [Updated version 12-19-19]

alanccai commented 4 years ago

@asood12 your table above isn't quite right for Below Donnells Reservoir - that IFR has one less Water Year Type category - please see my word doc. But it's correct for all the others IFRs you listed.

asood12 commented 4 years ago

@alanccai - one less category is because they have merged "Normal-Dry" and "Normal-Wet" into a single category of "Normal".

alanccai commented 4 years ago

Hi Aditya, you're right - it would be simple to code that situation.

alanccai commented 4 years ago

USJ WYT Classification CSV files.zip USJ WYT classification parameters.docx

alanccai commented 4 years ago

Merced WYT Classification CSV files.zip Merced WYT classification parameters.docx

Note: This IFR, Below Merced Falls At Shaffer Bridge, does not currently exist in OpenAgua.

alanccai commented 4 years ago

Tuolumne WYT Classificiation CSV files.zip Tuolumne.WYT.classification.parameters.docx [updated 12/23/19]

GateauXD commented 4 years ago

Added WYT 2019 and WYT 2130 for Stan

See: https://github.com/vicelab/sierra-pywr/commit/afda652745d5fd31366c4ad64e8faa56e7de84cc

drheinheimer commented 4 years ago

Here is an updated list of locations that need Q/C, from @GustavoFacincani:

3 IFRs use the SJI:

drheinheimer commented 4 years ago

Follow-up notes: