vicelab / cen-sierra-pywr

Code base for modeling the central Sierra Nevada hydropower systems
4 stars 5 forks source link

Instream flow requirement (IFR) accuracy check #9

Closed drheinheimer closed 4 years ago

drheinheimer commented 4 years ago

This issue is to document checking instream flow requirements with actual code. I.e., the code in each of the basin models should reflect what the IFR actually is.

GateauXD commented 4 years ago

Related Issue: https://github.com/vicelab/sierra-pywr/issues/41

GustavoFacincani commented 4 years ago

IFR below La Grange Diversion Dam: not all numbers in the pseudocode match the SJ index (use SJ index numbers instead!).

GustavoFacincani commented 4 years ago

IFR below O'Shaughnessy Dam: A minimal difference from document: March 1-31, condition: if precipitation is >18.6 (not 18).

GustavoFacincani commented 4 years ago

Don Pedro Reservoir: Minimum pool is 550, not 600, according to the following: Article 403. Minimum Pool at Don Pedro Reservoir. The licensees must maintain a minimum pool elevation in Don Pedro Reservoir of not less than 550 feet National Geodetic Vertical Datum of 1929, except for drawdowns necessary to maintain minimum streamflows specified in article 409 (Minimum Flows below La Grange Diversion Dam).

drheinheimer commented 4 years ago

This issue is somewhat nebulous. Closing