vicelyav / pe

0 stars 0 forks source link

Duplicate email not addressed properly #9

Open vicelyav opened 1 week ago

vicelyav commented 1 week ago

Reason: In an educational institution, usually the emails are unique to each student to allow for easy identification, not just student id. This duplication would make users confused on which student is which.

Students usually need to provide uniq Example:

add 13132323 n/name2 p/123458999 e/johddd3doe@example.com a/123Fample Street c/Computer Science r/Student

add 13132324 n/name2 p/123458999 e/johddd3doe@example.com a/123Fample Street c/Computer Science r/Student

Expected: an exception message that tells the students should have unique email or phone.

soc-se-bot commented 1 week ago

Team's Response

We currently allow duplicates for all other fields, except for student ID as we consider student ID the unique identifier for students. However, under planned enhancement #4 in our developer's guide, we have highlighted our plans to change this in the future. This will allow us to have more robust duplicate detections for other fields, introducing a stronger identification mechanism.

We have thus rejected this bug as it is addressed under our planned enhancements.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand that you are considering enhanced person identification in the planned enhancement that you mentioned. However, this issue of duplicate email not being handled properly is not only for unique identifier purposes, but also an inconvenience in the case when users mistype a new email, which results in the duplication of email in the system. In this case, the email is not used as a unique identifier, but the lack of email duplication prevention still results in potential confusion for users when differentiating two contacts.

Furthermore, in my opinion, your Planned Enhancements section do not specify that email will be the unique identifier used in the upcoming versions:

Screenshot 2024-11-19 at 8.53.39 PM.png

The flexible identification field or unique identifiers could be either phone number or email or address, or an additional class that allows for differing identification of the roles. However, this does not fulfil the requirement stipulated by the course website for the Planned Enhancements to be specific:

Screenshot 2024-11-19 at 8.56.55 PM.png

It is due to the vagueness of the Planned Enhancement section, I decided to submit this flaw as a bug.