vichan-devel / vichan

Vichan is the most popular and widely used imageboard software in the world. It is a free, light-weight, fast, highly configurable and user-friendly imageboard software package.
https://vichan.info
Other
626 stars 194 forks source link

Dockerize Vichan #721

Closed Zankaria closed 5 months ago

Zankaria commented 5 months ago

This is (as the name suggests) a docker enablement patch. A lot of the changes come from leftypol. I mostly done this to simplify local testing (the compose stuff is manly aimed at that) and make bugs more reproducible. I do believe though that the vichan container can be used for production deployments.

Right now it doesn't come with any form of caching beside the php native stuff and the Redis driver. In order to keep data around, those who use it should bind mount a host folder into /var/www.

crazy4cars69 commented 5 months ago

Why? PHP, NGINX and Mysql is pretty basic internet tools since the internet was born and is super easy to setup, (((docker))) only needed for more shitty software that use jewscript or any other worthless globohomo garbage.

Zankaria commented 5 months ago

Why?

Docker greatly simplifies testing, making everyone able to set up a reproducible environment with a single command on all platforms without having to spread a bunch of software and configuration all over their systems (which they will then have to remember why they installed it and if there are any other things that depend on that can be removed, etc) This also simplifies having conflicting software versions by containerizing them.

PHP, NGINX and Mysql is pretty basic internet tools since the internet was born and is super easy to setup

So is easy sending paper letters instead of emails and easy digging wells. Doesn't mean there aren't better ways to do it once the tech is there.

(((docker))) only needed for more shitty software that use jewscript or any other worthless globohomo garbage.

This is just emotive boomerite cope. If you use it unironically please go back to your old's people hospice.

RealAngeleno commented 5 months ago

Hugely controversial PR so will keep open.

Zankaria commented 5 months ago

Hugely controversial PR so will keep open.

Hugely? It's one dude who thinks big nose™ is out promoting software he doesn't like because they're ontologically mean or something.

On top of that, this PR is exclusively additive, it doesn't aim to preclude in any way, shape or form from installing vichan with more traditional method.

RealAngeleno commented 5 months ago

My question then becomes. With this pr, is docker now mandatory to install vichan? If it becomes an optional setup then I'll merge it no questions, as I've had my own personal gripes with it, as well some others I talk to.

RealAngeleno commented 5 months ago

or a submodule

Zankaria commented 5 months ago

My question then becomes. With this pr, is docker now mandatory to install vichan?

Absolutely not. It's intended to be purely additive in functionality and not create any new mandatory requirements or limitations. If this PR introduces a requirement for any special handling of a non-docker vichan installation, I would consider that a regression that ought to be addressed and fixed

or a submodule

I am not sure what you're asking here...?