vicio-code / primeiro-ciclo-de-mentoria

Acompanhamento monitoria podcodar

1 stars 0 forks source link

Organizar projeto #6

Open frattezi opened 3 years ago

frattezi commented 3 years ago

Para este projeto vamos criar uma configuração mínima de pastas

src/
|
| --- components/
      |
      | --- core/ # commom components
      | --- GeneralComponents.js ...
| --- assets/
     | --- img.png
| --- pages/
     |
     | --- MyPage.js
| --- index.js # app entrypoint
| --- app.js # app setup

Aproveite e remova arquivos não utilizados e que vieram com o setup básico do react

vicio-code commented 3 years ago

https://github.com/vicio-code/base-projects/tree/js-react-base-project

frattezi commented 3 years ago

Review

File name

This file inherited the title from it's first line.

The doc is really nice!

React hot loader

This module is being considered as a dependency, which means it will be bundled in the final build, is this right?

APP serve

Your app is serving in door 8080, 8080 it's a really important door in CS, please change it to 3000 and consider it as a nice default value (low incidence from other programs).

vicio-code commented 3 years ago

File Name

Removed the file from repo and created a wiki page. https://github.com/vicio-code/base-projects/wiki

React Hot Loader

React Hot Loader doc says this:

The webpack patch, hot, Babel plugin, @hot-loader/react-dom etc. are all safe to use in production; they leave a minimal footprint, so there is no need to complicate your configuration based on the environment. Using the Babel plugin in production is even recommended because it switches to cleanup mode.

I don't fully understand, but I think it's ok.

App Serve

Changed the webpack.config.js and package.json