Add equality - Githubissues

vickumar1981 commented 9 months ago

github-actions[bot] commented 9 months ago

Coverage Report

File	Stmts	Miss	Cover	Missing
pyeffects
Either.py	42	2	95%	101, 116
Future.py	94	6	94%	80, 224–225, 248–249, 260
Monad.py	43	1	98%	16
Option.py	39	2	95%	99, 111
Try.py	61	2	97%	106, 199
__version__.py	9	9	0%	1–9
TOTAL	290	22	92%

Tests	Skipped	Failures	Errors	Time
77	0 :zzz:	0 :x:	0 :fire:	1.822s :stopwatch:

vickumar1981 commented 9 months ago

@BattiniSandeep I pulled in your changes as part of this PR.

Some notes:

Updated to using black: https://github.com/psf/black, over flake8.
I kept getting some error with the 3.11 build complaining it couldn't find the module typing-extensions, so I've currently disabled the 3.11 build in the github actions. Will create a separate issue for fixing the 3.11 build.
@BattiniSandeep , I gave you a bad comment about updating the signature of __eq__.

The signature of __eq__ should allow comparisons against other types, i.e.:

def __eq__(self, other: object) -> bool:

so object was 100% correct here from your previous commit.

I moved the __eq__ operator up to the parent class instead of the respective subclasses, so there's only one implementation each for Option, Try, and Either, instead of separate ones for say Some and then None.

vickumar1981 commented 9 months ago

vickumar1981 / pyeffects