search

vickumar1981 / stringdistance

A fuzzy matching string distance library for Scala and Java that includes Levenshtein distance, Jaro distance, Jaro-Winkler distance, Dice coefficient, N-Gram similarity, Cosine similarity, Jaccard similarity, Longest common subsequence, Hamming distance, and more..
https://vickumar1981.github.io/stringdistance/api/com/github/vickumar1981/stringdistance/index.html
Other
78 stars 15 forks source link

Add back compatibility with Scala 2.11 #50

Closed vickumar1981 closed 4 years ago

vickumar1981 commented 4 years ago

Spark EMR currently still uses the 2.11 compiler.

This commit: https://github.com/vickumar1981/stringdistance/commit/7dfbb7606434ef7076ece421e6d9658907ebc3c8 dropped support for 2.11.

Add back in compatibility with Scala 2.11

vickumar1981 commented 4 years ago

Pushed 1.2.3-SNAPSHOT, available for Scala 2.11: https://oss.sonatype.org/content/repositories/snapshots/com/github/vickumar1981/stringdistance_2.11/1.2.3-SNAPSHOT/

Need to test that this works with Scala 2.11 and can merge into master.

vickumar1981 commented 4 years ago

Addressed by https://github.com/vickumar1981/stringdistance/pull/51.

Version 1.2.3 should be cross-compiled for Scala 2.11, 2.12, & 2.13.

mzhao577 commented 4 years ago

Hi Vic,

This is wonderful! I will give it a test from my side and let you know the testing result.

Have wonderful weekends!

Max

On Thu, Jun 18, 2020 at 11:46 PM Vic Kumar notifications@github.com wrote:

Pushed a 1.2.3-SNAPSHOT that is available for Scala 2.11: https://oss.sonatype.org/content/repositories/snapshots/com/github/vickumar1981/stringdistance_2.11/1.2.3-SNAPSHOT/

Need to test that this works with Scala 2.11 and can merge into master.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vickumar1981/stringdistance/issues/50#issuecomment-646419113, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ2USTX6UVDORJ4I35MOZ3RXLNRHANCNFSM4NY7MEKQ .

vickumar1981 commented 4 years ago

@mzhao577 Did the 1.2.3 version work for you with Scala 2.11?

mzhao577 commented 4 years ago

Hi Vic,

I just tested 1 case that I used most, the levenshstein distance and score. It looks great.

I plan to run all the other tests listed in your GitHub testing cases. I am doing it now. I will get you updated once I got it ran.

Max

On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar notifications@github.com wrote:

@mzhao577 https://github.com/mzhao577 Did the 1.2.3 version work for you with Scala 2.11?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vickumar1981/stringdistance/issues/50#issuecomment-650811297, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ .

vickumar1981 commented 4 years ago

Thanks Max.

If you do add any more algorithms, please feel free to PR the repo if you think they'd be useful to others.

I'll probably be doing a few more updates in a couple of weeks - nothing heavy, just adding more documentation and maybe putting scalafmt to auto-format all the files.

Appreciate it. Cheers.

Vic Kumar vickumar@gmail.com

On Sun, Jun 28, 2020 at 9:44 PM Max Zhao notifications@github.com wrote:

Hi Vic,

I just tested 1 case that I used most, the levenshstein distance and score. It looks great.

I plan to run all the other tests listed in your GitHub testing cases. I am doing it now. I will get you updated once I got it ran.

Max

On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar notifications@github.com wrote:

@mzhao577 https://github.com/mzhao577 Did the 1.2.3 version work for you with Scala 2.11?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/vickumar1981/stringdistance/issues/50#issuecomment-650811297 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/vickumar1981/stringdistance/issues/50#issuecomment-650859040, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTQHMA3LVWTICNW27RJIRLRY7WXZANCNFSM4NY7MEKQ .

mzhao577 commented 4 years ago

Hi Vic,

I was busy recently. I will do more testing once I get more free time.

Your code is very useful. Please keep it up!

If there are things I can do to help. Please do not hesitate to reach out to me.

Thanks for your wonderful work!

Max

On Mon, Jun 29, 2020 at 11:12 AM Vic Kumar notifications@github.com wrote:

Thanks Max.

If you do add any more algorithms, please feel free to PR the repo if you think they'd be useful to others.

I'll probably be doing a few more updates in a couple of weeks - nothing heavy, just adding more documentation and maybe putting scalafmt to auto-format all the files.

Appreciate it. Cheers.

Vic Kumar vickumar@gmail.com

On Sun, Jun 28, 2020 at 9:44 PM Max Zhao notifications@github.com wrote:

Hi Vic,

I just tested 1 case that I used most, the levenshstein distance and score. It looks great.

I plan to run all the other tests listed in your GitHub testing cases. I am doing it now. I will get you updated once I got it ran.

Max

On Sun, Jun 28, 2020 at 3:33 PM Vic Kumar notifications@github.com wrote:

@mzhao577 https://github.com/mzhao577 Did the 1.2.3 version work for you with Scala 2.11?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/vickumar1981/stringdistance/issues/50#issuecomment-650811297

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABZ2USTSIPV34OGZXP6DUE3RY6LIVANCNFSM4NY7MEKQ

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/vickumar1981/stringdistance/issues/50#issuecomment-650859040 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABTQHMA3LVWTICNW27RJIRLRY7WXZANCNFSM4NY7MEKQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vickumar1981/stringdistance/issues/50#issuecomment-651184255, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ2USUZ4JEBFW7Q66TSLTTRZCVMLANCNFSM4NY7MEKQ .