vickumar1981 / stringdistance

A fuzzy matching string distance library for Scala and Java that includes Levenshtein distance, Jaro distance, Jaro-Winkler distance, Dice coefficient, N-Gram similarity, Cosine similarity, Jaccard similarity, Longest common subsequence, Hamming distance, and more..
https://vickumar1981.github.io/stringdistance/api/com/github/vickumar1981/stringdistance/index.html
Other
78 stars 15 forks source link

Add some extra TestSoundCases #58

Closed JD557 closed 4 years ago

JD557 commented 4 years ago

Adds some extra test sound cases to increase the test coverage.

This brings the SoundexAlgo coverage close to 100%, but unfortunately I don't know enough about the algorithm to trigger the missing edge cases.

This also improves the MetaphoneAlgo coverage, but again, since I'm not very familiar with the algorithm, it's hard to generate the edge cases.

I also removed a String -> Array[Char] conversion to improve the test coverage. I also think that this might slightly improve performance (since the conversion happens later, and only if needed), but I haven't benchmarked it.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 229


Totals Coverage Status
Change from base Build 228: 1.9%
Covered Lines: 364
Relevant Lines: 374

💛 - Coveralls
vickumar1981 commented 4 years ago

Relates to issues: