search

vickychijwani / quill

:ghost: [MOVED TO https://github.com/TryGhost/Ghost-Android] The beautiful Android app for your Ghost blog.
MIT License
553 stars 84 forks source link

Use Chrome Custom Tabs instead of WebView #100

Closed vickychijwani closed 7 years ago

vickychijwani commented 9 years ago

This does not necessarily have to ship in 1.0, but it might just fix #75 for Jellybean and greater if it turns out that the preview can be powered by custom tabs alone. (EDIT: nope)

It must be kept in mind that custom tabs do not work for platforms < JB, so WebViews will have to be used there (unless support for ICS is dropped: #101).

More info: https://developer.chrome.com/multidevice/android/customtabs

vickychijwani commented 9 years ago

It appears Chrome custom tabs are not suited for hosting local content (like the preview.html file in this case). Custom tabs can still be used when displaying actual blog pages, but then it's not that much of an improvement :disappointed:

vickychijwani commented 7 years ago

Turns out Chrome Custom Tabs are needed to resolve #149 anyway, so we can use them for Android >= 4.1, and normal WebView for previous versions.

The way custom tabs work is by generating a normal ACTION_VIEW intent with some additional parameters like Toolbar color, that Chrome picks up if it is the default browser. If some other browser is the default, the link will instead open in that browser.