gitguardian[bot]
commented
2 months ago ⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [13608298](https://dashboard.gitguardian.com/workspace/288000/incidents/13608298?occurrence=164331499) | Triggered | Mapbox Token | add82abe6034bdfd3e41f105d9c2787e7f5bdc4d | app.json | [View secret](https://github.com/vickystickz/CampusGuide-mobile/commit/add82abe6034bdfd3e41f105d9c2787e7f5bdc4d#diff-96677aa35debfefd031d9d34d9c70369754ee3acb2d9a9d4090e98612efee6f5R36) | | [13608298](https://dashboard.gitguardian.com/workspace/288000/incidents/13608298?occurrence=164331500) | Triggered | Mapbox Token | c27b7adf211b629a386e8d8de6c5f255a57cc4e1 | app.json | [View secret](https://github.com/vickystickz/CampusGuide-mobile/commit/c27b7adf211b629a386e8d8de6c5f255a57cc4e1#diff-96677aa35debfefd031d9d34d9c70369754ee3acb2d9a9d4090e98612efee6f5L36) | | [13608298](https://dashboard.gitguardian.com/workspace/288000/incidents/13608298?occurrence=164331502) | Triggered | Mapbox Token | add82abe6034bdfd3e41f105d9c2787e7f5bdc4d | android/build.gradle | [View secret](https://github.com/vickystickz/CampusGuide-mobile/commit/add82abe6034bdfd3e41f105d9c2787e7f5bdc4d#diff-197b190e4a3512994d2cebed8aff5479ff88e136b8cc7a4b148ec9c3945bd65aR58) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/mapbox_secret_token#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
vickystickz
This PR will close #3 and partially #4 (except the search).
Significant progress has been made, and a copy has been built as an APK for testing: You can download it here (https://drive.google.com/file/d/12nO6oxjQwgKNcY_97Sgom22pI2wr8x8v/view?usp=sharing)
I used Expo for the build process - it's super easy (which means, a new copy can be built easily whenever there is a new update, just let me know), or you can also create your account - I followed this resource (https://dev.to/chinmaymhatre/how-to-generate-apk-using-react-native-expo-kae)
I tested it on my Samsung S21 and it works fine.
The only major thing left is the turn-by-turn instructions. Unfortunately, I have to attend to other tasks this weekend and in the coming month, so I can't guarantee my availability.
However, whenever I'm free in the future, I'll contribute.
It's my first application, so I'm excited about it, and I know it won't be perfect, so please feel free to correct any issues you spot in the codebase :)
Thank you for the opportunity to contribute, and for trusting in my abilities!
I hope this is sufficient enough for the MVP demo at the conference :)