search

viclafouch / mui-tel-input

📌 A phone number input designed for MUI (Material ui) V6 built with libphonenumber-js
https://viclafouch.github.io/mui-tel-input
MIT License
171 stars 67 forks source link

expose IconButtonProps for FlagButton #120

Closed alextrukhan closed 8 months ago

alextrukhan commented 9 months ago

expose IconButtonProps for FlagButton to allow to customize some behavior/styling of the button via props. not sure if whole props are needed. Example: to disable ripple effect on props level instead of adding some custom styling around the input

viclafouch commented 9 months ago

Hello @alextrukhan !

Humm, i'm not sure about your changes. As you know FlagButton is an internal component, and users don't really what is it, or what are the props for this. So the devx can be really confused.

To be sure to understand, you want to disable the ripple effect on the button, right?

alextrukhan commented 9 months ago

Hi, @viclafouch. you are right. I want to disable rippleEffect on button. but possibly may want to change some other styles of the flag button. imho: mui exposes props of all underlying components for TextField, so it is possible to customize all its parts, so maybe it is also worth to expose props for all underlying components as you did with MenuProps for example. maybe not all props will be used. or maybe at least expose all styles related props for the button. what do you think?

viclafouch commented 8 months ago

Hummmm after a long delay (sorry), I take the decision to not editing any style for the button. This package is following the Material guidelines.

I think I will reopen this PR is there are more upvote. I need more engagments on this.