search

viclovsky / swagger-coverage

Tool which generates full picture of coverage of API tests based on OAS (Swagger) v2 and v3
Apache License 2.0
197 stars 38 forks source link

replace log4j with logback #100

Closed majran closed 2 years ago

majran commented 2 years ago

I've removed log4j because of vulnerability issue and replaced with logback.

viclovsky commented 2 years ago

Hi, @majran
I have tried your changes and caught an issue on calling run.sh (see below) . Could you have a look? 

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/Users/vicdev/IdeaProjects/swagger-coverage/swagger-coverage-commandline-1.0-SNAPSHOT/lib/slf4j-simple-1.7.30.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Users/vicdev/IdeaProjects/swagger-coverage/swagger-coverage-commandline-1.0-SNAPSHOT/lib/logback-classic-1.2.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory]
Exception in thread "main" java.lang.ClassCastException: class org.slf4j.impl.SimpleLogger cannot be cast to class ch.qos.logback.classic.Logger (org.slf4j.impl.SimpleLogger and ch.qos.logback.classic.Logger are in unnamed module of loader 'app')
        at com.github.viclovsky.swagger.coverage.CommandLine.run(CommandLine.java:59)
        at java.base/java.util.Optional.orElseGet(Optional.java:369)
        at com.github.viclovsky.swagger.coverage.CommandLine.main(CommandLine.java:34)
majran commented 2 years ago

Hi @viclovsky, yep, found it and fixed dependencies. Seems to be ok now 😺 .