viclovsky / swagger-coverage

Tool which generates full picture of coverage of API tests based on OAS (Swagger) v2 and v3
Apache License 2.0
198 stars 37 forks source link

swagger-coverage-commons should not depend on logback (only slf4j) #111

Closed u3r closed 1 year ago

u3r commented 2 years ago

I'm submitting a ...

What is the current behavior?

swagger-coverage-commons has a direct dependency implementation("ch.qos.logback:logback-classic") on logback

If the current behavior is a bug, please provide steps to reproduce, broken swagger specification and swagger-coverage-output:

build and check transitive dependencies when importing.

What is the expected behavior?

swagger-coverage-commons should only have a transitive dependency on slf4j. If needed for testing, replace with testImplementation("ch.qos.logback:logback-classic") otherwise just drop this dependency (and rely on dependent code (e.g. CLI) to declare the actual implementation.

What is the motivation / use case for changing the behavior?

If not implemented all the benefit of SLF4J is wasted.