search

vicoapp / vico

Mac Programmers Text Editor
http://www.vicoapp.com/
658 stars 89 forks source link

Can't get `make run` to compile Vico with permission-related git-submodule messages. #43

Closed godDLL closed 11 years ago

godDLL commented 11 years ago

@Shadowfiend the cryptic submodule-related message is still there. 

$ make run
…
Submodule 'plblockimp' (https://github.com/landonf/plblockimp.git) registered for path 'plblockimp'
Submodule 'sparkle' (https://github.com/andymatuschak/Sparkle.git) registered for path 'sparkle'
Cloning into 'Bundles/vicoapp-ack.vico-bundle'...
Permission denied (publickey).
fatal: The remote end hung up unexpectedly
Clone of 'git@github.com:vicoapp/ack.vico-bundle.git' into submodule path 'Bundles/vicoapp-ack.vico-bundle' failed
make: *** [/Users/yuli/Downloads/vico/build/DEBUG/gitmodules.stamp] Error 1
#12:53:33!2 vico:merged$
Shadowfiend commented 11 years ago

Got it. Okay, so Github URLs don't work quite the way I thought. git@github.com:vicoapp/ack.vico-bundle.git would work for you even if you're not a contributor, but would give you a read-only repository (i.e., push wouldn't work). However! It tries to clone via SSH.

Do you currently have a public key configured in Github?

godDLL commented 11 years ago

I installed GitHub for Mac at some point, so yes. How do I get around that issue? If I remove the key I get this:

fatal: Needed a single revision
Unable to find current revision in submodule path 'Bundles/vicoapp-ack.vico-bundle'
make: *** [/Users/yuli/Downloads/vico/build/DEBUG/gitmodules.stamp] Error 1

EDIT: which is normal because the build target dir is unclean.

godDLL commented 11 years ago

Deleting and re-adding the GitHub key, followed by a make clean and rm -Rf Bundles/* build/* solved it. I've literally been stuck in this situation for months. Thanks @Shadowfiend !

Shadowfiend commented 11 years ago

Still an odd one. We could switch the submodule references to use non-SSH paths, but that would make it more difficult to work on the bundles (you'd have to clone them separately). A nightly is probably a better solution.

godDLL commented 11 years ago

I'd like to stress that just deleting the faulty 'older' (the same as now, btw) SSH key did not fix it. I had to add it anew, so yes. Nightly is the way. :D