vicoapp / vico

Mac Programmers Text Editor
http://www.vicoapp.com/
658 stars 89 forks source link

:s fixes/tweaks #45

Closed Shadowfiend closed 11 years ago

Shadowfiend commented 11 years ago

I'm going to generally follow a policy of keeping a pull request open for my own stuff for at least a week to gather any feedback the community may want to give for now; this can evolve as the community grows. If I open a pull request and don't see any activity for a week, I'll go ahead and merge it in. Likewise, I'll try to give feedback on any requests I see within a week if at all possible.

This PR does a variety of things with the :s/:substitute command, and fixes a couple of incidental issues because I ran into them as I was making these changes. Here's a list:

Shadowfiend commented 11 years ago

I would highly appreciate it if folks would use this branch for a little bit this week and see if it interferes with any of your day-to-day :s usage. I will be doing the same :)

Shadowfiend commented 11 years ago

There is at least one issue with infinite looping going on in the new transform implementation, which can be triggered by trying to add a new function on a new line at the beginning of the line in an Objective-C header file. I'll be investigating this tonight or tomorrow.

Shadowfiend commented 11 years ago

Looks like this gentleman isn't properly respecting replacement ranges (it always operates on the whole file). Fix to come.

Shadowfiend commented 11 years ago

Finally fixed the range issues with this branch. Going to use it for a couple of days and see if everything seems kosher; if it does, then I'm going to go ahead and merge the branch unless I hear something :)

Shadowfiend commented 11 years ago

Merging this lovely lady in; please file an issue if you run into any problems with the new implementation.