search

vicoapp / vico

Mac Programmers Text Editor
http://www.vicoapp.com/
658 stars 89 forks source link

Better “project” support #46

Closed Shadowfiend closed 11 years ago

Shadowfiend commented 11 years ago

In particular, remembering split layout and open buffers for a given directory would be nice.

Note: the diff here currently includes commits from arc-reactor; those will go away once that branch is merged.

peteschaffner commented 11 years ago

This is great! The only thing I've noticed thus far is that every time you quit, relaunch and then open a saved "project" ... Vico reverses the order of opened tabs. Other than that, tabs, caret and scroll offset, and splits all seem to be saved!

I wonder, have you considered supporting the global pref added in Lion (or perhaps ML, not sure) for saving window/tab state on quit, so that upon relaunch, the same "projects" open at last quit, are opened automatically?

Window restore

Shadowfiend commented 11 years ago

Yep, restoring the last open project(s) is definitely part of this.

Thanks for letting me know about tabs. I don't use them much so having someone checking things who does is handy ;)

peteschaffner commented 11 years ago

Cool!

Shadowfiend commented 11 years ago

Actually, I may fix tab ordering and then leave resume support for something separate. I want to integrate Auto Save as well, and those two will dovetail nicely.

Shadowfiend commented 11 years ago

Ok, I currently consider this ready to go. Bug reports welcome!

peteschaffner commented 11 years ago

Love the commit message :P Ok cool. I will build after work and see if I can't break anything ;)

Shadowfiend commented 11 years ago

Rockin'!

peteschaffner commented 11 years ago

So far so good for me!

peteschaffner commented 11 years ago

Shit I spoke too soon. I am noticing some weird reordering with the second and third open tabs ... let me play with it some more (with different tab counts) and try to pin down the logic behind whats happening.

Shadowfiend commented 11 years ago

All right, let me know what you find. Any consistency to it?

peteschaffner commented 11 years ago

Sorry for the delay :| I think I see whats happening now. The original tab order (i.e. the one created when opening/closing a tab) seems to be preserved, but any new order established via rearranging the tabs is not preserved.

Shadowfiend commented 11 years ago

So if you open a set of tabs, rearrange them, then close the project window, reopening it gets it to you in the originally-opened order rather than the rearranged one?

peteschaffner commented 11 years ago

You got it!

peteschaffner commented 11 years ago

Guess I could have said that in english the first time ;)

Shadowfiend commented 11 years ago

Haha no worries, I had enough information, just wanted to articulate it clearly and make sure I didn't misunderstand.

Looks like I made some assumptions about how tabs are reported back that weren't true. I'll look at it tonight and see if I can't fix it.

peteschaffner commented 11 years ago

Nice. Thanks!

Shadowfiend commented 11 years ago

This should now be fixed.

peteschaffner commented 11 years ago

Fixed for me!

Shadowfiend commented 11 years ago

Ok, I think I'm going to go ahead and merge this baby if there are no further issues. I'll give it a day and merge it tomorrow (October 14th) evening, EDT.

peteschaffner commented 11 years ago

Cool. Yeah nothing to report but good things on my end, so I say merge away!

Shadowfiend commented 11 years ago

!

Shadowfiend commented 11 years ago

One last fix in, once @farmdawgnation confirms this is kosher I'll merge 'er in.

farmdawgnation commented 11 years ago

:+1: